Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nongcheap test #89711

Merged
merged 8 commits into from
Jul 31, 2023
Merged

Fix nongcheap test #89711

merged 8 commits into from
Jul 31, 2023

Conversation

EgorBo
Copy link
Member

@EgorBo EgorBo commented Jul 31, 2023

Fixes #88507

It seems that it was assumed that ULONG is 64-bit type (which is not), replaced with stdint

@ghost
Copy link

ghost commented Jul 31, 2023

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

Issue Details

To fix #88507

Author: EgorBo
Assignees: -
Labels:

area-Diagnostics-coreclr

Milestone: -

@EgorBo
Copy link
Member Author

EgorBo commented Jul 31, 2023

/azp list

@azure-pipelines
Copy link

CI/CD Pipelines for this repository:

@EgorBo
Copy link
Member Author

EgorBo commented Jul 31, 2023

/azp run runtime-coreclr jitstress2-jitstressregs, runtime-coreclr jitstressregs

@azure-pipelines
Copy link

No commit pushedDate could be found for PR 89711 in repo dotnet/runtime

@EgorBo
Copy link
Member Author

EgorBo commented Jul 31, 2023

/azp run runtime-coreclr jitstress2-jitstressregs, runtime-coreclr jitstressregs

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@EgorBo EgorBo changed the title Add more verbose logging to nongcheap test Fix nongcheap test Jul 31, 2023
@EgorBo
Copy link
Member Author

EgorBo commented Jul 31, 2023

/azp run runtime-coreclr jitstress2-jitstressregs, runtime-coreclr jitstressregs

@azure-pipelines
Copy link

No commit pushedDate could be found for PR 89711 in repo dotnet/runtime

@EgorBo
Copy link
Member Author

EgorBo commented Jul 31, 2023

/azp run runtime-coreclr jitstress2-jitstressregs, runtime-coreclr jitstressregs

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@EgorBo EgorBo marked this pull request as ready for review July 31, 2023 13:31
@EgorBo
Copy link
Member Author

EgorBo commented Jul 31, 2023

@cshung PTAL, this fixes #88507

the crash was basically:

GetNonGCHeapBounds (segCount = 1):
seg#0, rangeStart=0xffc858bb1008, rangeLength=6640, rangeLengthReserved=4194296

GetGenerationBounds (segCount = 5):
seg#0, rangeStart=0xff8854000028, rangeLength=16368, rangeLengthReserved=33554392
seg#1, rangeStart=0xff8856c00028, rangeLength=0, rangeLengthReserved=33554392
seg#2, rangeStart=0xff8858c00028, rangeLength=0, rangeLengthReserved=4194264
seg#3, rangeStart=0xff8856800028, rangeLength=40544, rangeLengthReserved=4194264
seg#4, rangeStart=0xff8856000028, rangeLength=0, rangeLengthReserved=4194264

Fail: Overlapping segments

it detected overlapping segments despite the fact they're not in fact overlapped - it happened because of mixing UINT_PTR (64-bit) and ULONG (32-bit even on 64-bit).

@EgorBo
Copy link
Member Author

EgorBo commented Jul 31, 2023

/azp run runtime-coreclr outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@cshung cshung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@EgorBo EgorBo merged commit 7fb4a3c into dotnet:main Jul 31, 2023
189 of 210 checks passed
@EgorBo EgorBo deleted the verbose-logging-nongc-test branch July 31, 2023 17:55
@ghost ghost locked as resolved and limited conversation to collaborators Aug 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test failure profiler/gc/nongcheap/nongcheap.sh
2 participants