Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve ArraySegment debugging #90488

Merged
merged 10 commits into from
Oct 30, 2023
Merged

Improve ArraySegment debugging #90488

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
ca14b99
Improve ArraySegment debugging
pedrobsaila Aug 13, 2023
451deac
fix build
pedrobsaila Aug 13, 2023
dc0b4ef
fix remarks
pedrobsaila Aug 14, 2023
18511fc
fix remark 2
pedrobsaila Aug 14, 2023
9c7de7c
fix build
pedrobsaila Aug 14, 2023
8d7ee67
fix build 2
pedrobsaila Aug 14, 2023
84f43fa
drop generics
pedrobsaila Aug 14, 2023
c06836c
Merge remote-tracking branch 'upstream/main' into 88961
pedrobsaila Oct 28, 2023
f220fdb
use simpler solution
pedrobsaila Oct 28, 2023
788687d
clean DebuggerToString
pedrobsaila Oct 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/libraries/System.Private.CoreLib/src/System/ArraySegment.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@ namespace System
// (ie, users could assign a new value to the old location).
[Serializable]
[TypeForwardedFrom("mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089")]
[DebuggerTypeProxy(typeof(ICollectionDebugView<>))]
[DebuggerDisplay("Count = {Count}")]
#pragma warning disable CA1066 // adding IEquatable<T> implementation could change semantics of code like that in xunit that queries for IEquatable vs enumerating contents
public readonly struct ArraySegment<T> : IList<T>, IReadOnlyList<T>
#pragma warning restore CA1066
Expand Down
Loading