-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/8.0-rc1] Unify with logging category matching #90642
Merged
carlossanlop
merged 3 commits into
release/8.0-rc1
from
backport/pr-90559-to-release/8.0-rc1
Aug 16, 2023
Merged
[release/8.0-rc1] Unify with logging category matching #90642
carlossanlop
merged 3 commits into
release/8.0-rc1
from
backport/pr-90559-to-release/8.0-rc1
Aug 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
needs-area-label
An area label is needed to ensure this gets routed to the appropriate area owners
label
Aug 15, 2023
tarekgh
added
Servicing-consider
Issue for next servicing release review
area-System.Diagnostics.Metric
and removed
needs-area-label
An area label is needed to ensure this gets routed to the appropriate area owners
labels
Aug 15, 2023
tarekgh
approved these changes
Aug 15, 2023
@Tratcher can you rebase the changes with release/8.0-rc1 |
Tratcher
force-pushed
the
backport/pr-90559-to-release/8.0-rc1
branch
from
August 16, 2023 15:24
4c2aa78
to
2554d8e
Compare
Rebased |
Tratcher
added
Servicing-approved
Approved for servicing release
and removed
Servicing-consider
Issue for next servicing release review
labels
Aug 16, 2023
@Tratcher I can bypass the "Update branch" restriction. Otherwise the CI will restart. Ping me when the CI finishes for this new re-run and I can merge it for you (no need to press on "Update branch" again). |
@carlossanlop ready when you are. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #90559 to release/8.0-rc1
There's a new feature to configure metrics in RC1. This PR addresses feedback about making the matching rules consistent with Logging.
Customer Impact
Consistent matching rules will make the config file formats easier to understand and document.
Testing
Unit tests
Risk
Low, the feature is new in rc1.