Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs][tests] Add Mono Profiled AOT Functional Test and doc #90959

Merged
merged 5 commits into from
Aug 24, 2023

Conversation

mdh1418
Copy link
Member

@mdh1418 mdh1418 commented Aug 22, 2023

This PR looks to add documentation surrounding Mono's dotnet-pgo based Profiled AOT story enabled through #69512. It also adds an Android functional test to test the Mono AOT Compiler ingesting a .mibc profile and a .nettrace.

@ghost
Copy link

ghost commented Aug 22, 2023

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

This PR looks to add documentation surrounding Mono's dotnet-pgo based Profiled AOT story enabled through #69512. It also adds an Android functional test to test the Mono AOT Compiler ingesting a .mibc profile and a .nettrace.

Author: mdh1418
Assignees: -
Labels:

area-Infrastructure-mono

Milestone: -

@@ -0,0 +1 @@
See [Profiled Ahead-Of-Time Compilation on Mono](https://github.com/dotnet/runtime/docs/design/mono/profiled-aot.md#android----running-through-the-android-profiled-aot-functional-test)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that link won't work since it's missing the branch name. Instead you can just use a relative link:

Suggested change
See [Profiled Ahead-Of-Time Compilation on Mono](https://github.com/dotnet/runtime/docs/design/mono/profiled-aot.md#android----running-through-the-android-profiled-aot-functional-test)
See [Profiled Ahead-Of-Time Compilation on Mono](/docs/design/mono/profiled-aot.md#android----running-through-the-android-profiled-aot-functional-test)


<!-- Profiled AOT with .mibc-->
<PropertyGroup>
<ProfiledAOTProfilePaths>$(MSBuildThisFileDirectory)\adeapt.mibc</ProfiledAOTProfilePaths>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you might want to call this just test.mibc and test.nettrace so it is clearer that these are test assets.

@mdh1418
Copy link
Member Author

mdh1418 commented Aug 23, 2023

/azp run runtime-android

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mdh1418
Copy link
Member Author

mdh1418 commented Aug 23, 2023

/azp run runtime-android

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mdh1418
Copy link
Member Author

mdh1418 commented Aug 23, 2023

/azp run runtime-android

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mdh1418
Copy link
Member Author

mdh1418 commented Aug 24, 2023

Test failure is issue #88843

@mdh1418 mdh1418 merged commit fd6d5fd into dotnet:main Aug 24, 2023
146 of 149 checks passed
@ghost ghost locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants