Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring AggressiveOptimization back on AwaitUnsafeOnCompleted #90966

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

EgorBo
Copy link
Member

@EgorBo EgorBo commented Aug 22, 2023

Fixes #90899

When T awaiter implements IStateMachineBoxAwareAwaiter (ValueTask) this function still emits allocations in Tier0. A minimal repro is illustrated in #90965

@ghost
Copy link

ghost commented Aug 22, 2023

Tagging subscribers to this area: @dotnet/area-system-runtime-compilerservices
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #90899

When T awaiter implements IStateMachineBoxAwareAwaiter (ValueTask) this function still emits allocations in Tier0. A minimal repro is illustrated in #90965

Author: EgorBo
Assignees: -
Labels:

area-System.Runtime.CompilerServices

Milestone: -

@EgorBo EgorBo merged commit 413eac8 into dotnet:main Aug 23, 2023
170 checks passed
@EgorBo EgorBo deleted the revert-remove-ao-async branch August 23, 2023 09:33
@EgorBo EgorBo restored the revert-remove-ao-async branch August 23, 2023 09:33
@EgorBo
Copy link
Member Author

EgorBo commented Aug 23, 2023

/backport to release/8.0

@github-actions
Copy link
Contributor

Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/5949593687

@EgorBo EgorBo deleted the revert-remove-ao-async branch August 23, 2023 10:04
@ghost ghost locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Performance regression, memory usage
2 participants