Adding a naive implementation of various primitive tensor operations #91228

tannergooding · 2023-08-28T19:36:38Z

No description provided.

dotnet-issue-labeler · 2023-08-28T19:36:45Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

ghost · 2023-08-28T19:36:50Z

Tagging subscribers to this area: @dotnet/area-system-numerics-tensors
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author:	tannergooding
Assignees:	tannergooding
Labels:	`area-System.Numerics.Tensors`, `new-api-needs-documentation`
Milestone:	-

stephentoub · 2023-08-28T20:17:48Z

src/libraries/System.Numerics.Tensors/src/System/Numerics/Tensors/TensorPrimitives.cs

+            for (int i = 0; i < x.Length; i++)
+            {
+                destination[i] = x[i] + y[i];
+            }


I assume the plan is to get the functionality merged and to then follow-up with vectorization in time for 8.0 as well?

Let me know if you want to divvy that up at all or if you're going to tackle it all yourself. Presumably we'll end up wanting a Vector<T> implementation for downlevel and a Vector128/256/512<T> for .NET 8+.

Yes. The general plan is to get this first bit (covering element-wise operations) in.

Work on vectorizing them can then start while the vector-based tensor operations (Signmoid, Product, Sum, etc) get their naive implementations in.

@michaelgsharp and I will be splitting the work, but you're more than welcome to join in and help as well!

Getting the naive implementation in gives us both a scalar fallback and a baseline against which correctness of the SIMD implementation can be validated.

I should have tests up here in just a little bit.

@michaelgsharp and I will be splitting the work, but you're more than welcome to join in and help as well!

Happy to help

src/libraries/System.Numerics.Tensors/src/System/Numerics/Tensors/TensorPrimitives.cs

tannergooding · 2023-08-30T16:38:21Z

CC. @michaelgsharp, @luisquintanilla, @stephentoub this should be ready for review.

As per the above this is just covering the simple "element-wise" functions and the naive implementations to give us a baseline. Once in, I'll move to the remaining "vector" functions and work on accelerating these using SIMD can happen as well, allowing more concurrent work.

CC. @ViktorHofer would appreciate if you could look over the project settings to make sure they look correct.

ViktorHofer · 2023-08-30T19:15:32Z

If the intent is to publicly ship this library going forward, you want to remove the properties in src\libraries\System.Numerics.Tensors\Directory.Build.props (and delete the file).

You would also need to update the README.md file which mentions that the library doesn't ship publicly.

michaelgsharp

Looks good to me. Probably still want another opinion though.

src/libraries/System.Numerics.Tensors/ref/System.Numerics.Tensors.csproj

src/libraries/System.Numerics.Tensors/src/System.Numerics.Tensors.csproj

stephentoub · 2023-09-01T00:51:06Z

src/libraries/System.Numerics.Tensors/tests/TensorPrimitivesTests.cs

+{
+    public static class TensorPrimitivesTests
+    {
+        private const int TensorSize = 512;


Do we have any tests for boundary conditions, e.g. empty? Or error conditions? Or is the plan for those to come separately?

I added tests for the exception cases already. I can add ones for empty as well.

For floating-point correctness cases (i.e. infinity, nan, -0, etc), I think it'd be good to add handling for after we move off the "naive" implementation.

src/libraries/System.Numerics.Tensors/tests/TensorPrimitivesTests.cs

Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com>

ViktorHofer · 2023-09-01T07:17:25Z

Please respond to my above question before merging: #91228 (comment)

…ping

tannergooding · 2023-09-01T19:57:20Z

Please respond to my above question before merging: #91228 (comment)

Removed the file that marked it as non-shipping and adjusted the readme.

ViktorHofer · 2023-09-02T08:22:54Z

src/libraries/System.Numerics.Tensors/README.md

+
+Provides APIs for performing primitive operations over tensors represented by spans of memory.


Would be good to update this README to the format that other libraries use, i.e. https://github.com/dotnet/runtime/blob/main/src/libraries/Microsoft.Extensions.Configuration.Abstractions/README.md. This can happen in a follow-up but please don't forget about it.

Also, as this package is now shipping officially, we should add a PACKAGE readme as well. I will add an entry in #91210 to track that work.

…otnet#91228) * Adding a naive implementation of various primitive tensor operations * Adding tests covering the new tensor primitives APIs * Adding tensor primitives APIs to the ref assembly * Allow .NET Framework to build/run * Sync TFMs between ref and src, csproj simplication and clean-up * Apply suggestions from code review Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com> * Don't use var * Fix the S.N.Tensors readme and remove the file marking it as non-shipping --------- Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com> Co-authored-by: Michael Sharp <51342856+michaelgsharp@users.noreply.github.com>

* added Bcl.Numerics * Adding a naive implementation of various primitive tensor operations (#91228) * Adding a naive implementation of various primitive tensor operations * Adding tests covering the new tensor primitives APIs * Adding tensor primitives APIs to the ref assembly * Allow .NET Framework to build/run * Sync TFMs between ref and src, csproj simplication and clean-up * Apply suggestions from code review Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com> * Don't use var * Fix the S.N.Tensors readme and remove the file marking it as non-shipping --------- Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com> Co-authored-by: Michael Sharp <51342856+michaelgsharp@users.noreply.github.com> * Start vectorizing TensorPrimitives (#91596) * Start vectorizing TensorPrimitives Just does two functions to establish the files into which the rest of the implementations can be moved. * 6 more naive methods for Tensor Primitives. (#92142) * 6 more naive methods * updates from pr comments * Add remaining set of TensorPrimitives APIs for .NET 8 (#92154) * Add remaining set of TensorPrimitives APIs for .NET 8 Adds non-vectorized implementations of: - Max - Min - MaxMagnitude - MinMagnitude - IndexOfMax - IndexOfMin - IndexOfMaxMagnitude - ConvertToHalf (only on .NET Core) - ConvertToSingle (only on .NET Core) - IndexOfMinMagnitude Adds vectorized implementations of: - Sum - SumOfSquares - SumOfMagnitudes - Product - ProductOfSums - ProductOfDifferences Also includes the helpers that'll make it trivial to vectorize Dot. Beyond vectorizing the non-vectorized ones, the vectorized implementations should be improved further, including: - Handling alignment better - Vectorizing the remainder that doesn't fit in a vector rather than falling back to scalar * Cleanup after previous PR, vectorize CosineSimilarity/Dot/L2Normalize/Distance, add tests * Address PR feedback, and fix a few other issues * Fix TensorPrimitives.CosineSimilarity to use vectorized implementations (#92204) * Fixed duplicated code from merge. * New Microsoft.BCL.Numerics package (#91074) * bcl numberics library added * bcl done * added explicit 2.1 target * Minor doc updates * Apply suggestions from code review Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com> * fixes from PR comments * minor csproj fixes * fixed ref target frameworks * minor ref csproj updates * minor csproj updates --------- Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com> * Microsoft.Bcl.Numerics.Tests: fix restore failure when DotNetBuildFromSource. (#91402) * Microsoft.Bcl.Numerics.Tests: fix restore failure when DotNetBuildFromSource. * Use NetCoreAppCurrent. * Try fix CI test failures. --------- Co-authored-by: Tanner Gooding <tagoo@outlook.com> Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com> Co-authored-by: Stephen Toub <stoub@microsoft.com> Co-authored-by: Tom Deseyn <tom.deseyn@gmail.com>

dotnet-issue-labeler bot added area-System.Numerics.Tensors new-api-needs-documentation labels Aug 28, 2023

ghost assigned tannergooding Aug 28, 2023

Adding a naive implementation of various primitive tensor operations

f3de9d0

tannergooding force-pushed the tensor branch from ae215bc to f3de9d0 Compare August 28, 2023 19:37

stephentoub reviewed Aug 28, 2023

View reviewed changes

src/libraries/System.Numerics.Tensors/src/System/Numerics/Tensors/TensorPrimitives.cs Show resolved Hide resolved

tannergooding added 2 commits August 29, 2023 09:08

Adding tests covering the new tensor primitives APIs

7e9b1c0

Adding tensor primitives APIs to the ref assembly

aee5f0e

tannergooding marked this pull request as ready for review August 29, 2023 17:52

build-analysis bot mentioned this pull request Aug 29, 2023

Build Failure on MacOS ARM64 Rid issue with sqlite #90434

Closed

Allow .NET Framework to build/run

c679d68

Sync TFMs between ref and src, csproj simplication and clean-up

f03e43c

michaelgsharp approved these changes Aug 31, 2023

View reviewed changes

ViktorHofer reviewed Aug 31, 2023

View reviewed changes

src/libraries/System.Numerics.Tensors/ref/System.Numerics.Tensors.csproj Outdated Show resolved Hide resolved

ViktorHofer reviewed Aug 31, 2023

View reviewed changes

src/libraries/System.Numerics.Tensors/src/System.Numerics.Tensors.csproj Outdated Show resolved Hide resolved

stephentoub reviewed Sep 1, 2023

View reviewed changes

src/libraries/System.Numerics.Tensors/tests/TensorPrimitivesTests.cs Outdated Show resolved Hide resolved

stephentoub approved these changes Sep 1, 2023

View reviewed changes

Apply suggestions from code review

237121f

Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com>

build-analysis bot mentioned this pull request Sep 1, 2023

Crash in Microsoft.Extensions.Logging.Generators.Roslyn4.0.Tests.WorkItemExecution #90019

Open

build-analysis bot mentioned this pull request Sep 1, 2023

[7.0][mono][arm64] futex-internal.h: No such file or directory - futex_wait_cancelable native crash in Microsoft.Extensions.Logging.Generators.Roslyn3.11.Tests #87444

Closed

tannergooding added 2 commits September 1, 2023 12:48

Don't use var

0557d17

Fix the S.N.Tensors readme and remove the file marking it as non-ship…

eb41227

…ping

ViktorHofer reviewed Sep 2, 2023

View reviewed changes

ViktorHofer approved these changes Sep 2, 2023

View reviewed changes

tannergooding merged commit 85259f6 into dotnet:main Sep 5, 2023
106 checks passed

tannergooding deleted the tensor branch September 5, 2023 13:44

tannergooding mentioned this pull request Sep 5, 2023

Update the System.Numerics.Tensors readme #91594

Open

ghost locked as resolved and limited conversation to collaborators Oct 5, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding a naive implementation of various primitive tensor operations #91228

Adding a naive implementation of various primitive tensor operations #91228

tannergooding commented Aug 28, 2023

dotnet-issue-labeler bot commented Aug 28, 2023

ghost commented Aug 28, 2023

stephentoub Aug 28, 2023

tannergooding Aug 28, 2023

tannergooding Aug 28, 2023

stephentoub Aug 30, 2023

tannergooding commented Aug 30, 2023

ViktorHofer commented Aug 30, 2023 •

edited

Loading

michaelgsharp left a comment

stephentoub Sep 1, 2023

tannergooding Sep 1, 2023

ViktorHofer commented Sep 1, 2023

tannergooding commented Sep 1, 2023

ViktorHofer Sep 2, 2023


		Provides APIs for performing primitive operations over tensors represented by spans of memory.

Adding a naive implementation of various primitive tensor operations #91228

Adding a naive implementation of various primitive tensor operations #91228

Conversation

tannergooding commented Aug 28, 2023

dotnet-issue-labeler bot commented Aug 28, 2023

ghost commented Aug 28, 2023

stephentoub Aug 28, 2023

Choose a reason for hiding this comment

tannergooding Aug 28, 2023

Choose a reason for hiding this comment

tannergooding Aug 28, 2023

Choose a reason for hiding this comment

stephentoub Aug 30, 2023

Choose a reason for hiding this comment

tannergooding commented Aug 30, 2023

ViktorHofer commented Aug 30, 2023 • edited Loading

michaelgsharp left a comment

Choose a reason for hiding this comment

stephentoub Sep 1, 2023

Choose a reason for hiding this comment

tannergooding Sep 1, 2023

Choose a reason for hiding this comment

ViktorHofer commented Sep 1, 2023

tannergooding commented Sep 1, 2023

ViktorHofer Sep 2, 2023

Choose a reason for hiding this comment

ViktorHofer commented Aug 30, 2023 •

edited

Loading