[release/8.0] Support Windows based ECDSA SignedCms #91247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Supports SignedCms signatured with an ECDSA key created by the Windows API or .NET Framework. These signatures store an EC public key OID rather than a hash specific ECDSA OID used in newer versions of dotnet. Fixes #77377
|
Tagging subscribers to this area: @dotnet/area-system-security, @bartonjs, @vcsjones Issue DetailsBackport of #91183 to release/8.0 Customer ImpactTestingRiskIMPORTANT: If this backport is for a servicing release, please verify that:
|
vcsjones
approved these changes
Aug 29, 2023
|
Failures were from a known test issue (that is now fixed): |
jeffhandley
approved these changes
Aug 30, 2023
jeffschwMSFT
approved these changes
Aug 30, 2023
jeffschwMSFT
added
Servicing-approved
Closed
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #91183 to release/8.0
/cc @jeffhandley @jborean93
Customer Impact
Reported by multiple customers at #77377. Customers that created a signed CMS using .NET Framework or Win32 APIs using an ECDSA key or certificate will not validate in .NET (Core). This hinders compatibility between .NET Framework / Win32 and .NET.
This change fixes the validation to be compatible with .NET Framework.
Testing
A unit test was introduced to verify the correct behavior and to prevent regressions.
Risk
Low. This is a small change that is not logically complex.