Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mono][ios] Call mono_gc_init_finalizer_thread to allow gc thread creation #91785

Merged
merged 2 commits into from
Sep 8, 2023

Conversation

kotlarmilos
Copy link
Member

This PR modifies the runtime.m Apple template to call the mono_gc_init_finalizer_thread. This function enables the creation of the finalizer thread. If the runtime is compiled with the lazy gc thread creation flag, embedders must call this function to initiate the finalizer. Otherwise, the function does nothing and the runtime creates the finalizer thread automatically.

Fixes #90012

@ghost
Copy link

ghost commented Sep 8, 2023

Tagging subscribers to 'os-ios': @steveisok, @akoeplinger, @kotlarmilos
See info in area-owners.md if you want to be subscribed.

Issue Details

This PR modifies the runtime.m Apple template to call the mono_gc_init_finalizer_thread. This function enables the creation of the finalizer thread. If the runtime is compiled with the lazy gc thread creation flag, embedders must call this function to initiate the finalizer. Otherwise, the function does nothing and the runtime creates the finalizer thread automatically.

Fixes #90012

Author: kotlarmilos
Assignees: kotlarmilos
Labels:

area-Codegen-AOT-mono, os-ios

Milestone: 9.0.0

@kotlarmilos
Copy link
Member Author

/azp run runtime-ioslike

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@lateralusX lateralusX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Please verify that the GC dump tests now runs on iOS/tvOS devices on CI.

Copy link
Member

@ivanpovazan ivanpovazan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@kotlarmilos
Copy link
Member Author

The test has executed successfully https://helix.dot.net/api/jobs/831b21f1-4098-4f60-a174-033d11d5c3cf/workitems/tracing_eventpipe?api-version=2019-06-17.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[mono][ios] Eventpipe gcdump test failing on apple mobile platforms
4 participants