[release/8.0] Revert "Emit less metadata for not-reflection-visible types (#91660)" #91989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
requested a review
from MichalStrehovsky
as a code owner
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas Issue DetailsBackport of #91988 to release/8.0 Customer ImpactTestingRiskIMPORTANT: If this backport is for a servicing release, please verify that:
|
vitek-karas
approved these changes
Sep 13, 2023
jeffschwMSFT
approved these changes
Sep 13, 2023
|
Not sure what is happening with the failures here can someone take a look? |
|
Same as #91984 |
|
suspected fix in #92011 |
|
tracking issue #92014 |
|
@carlossanlop please merge this asap |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #91988 to release/8.0
/cc @MichalStrehovsky
Customer Impact
This is a rollback of #91703 that merged a couple days ago.
The fix had to be reverted because it essentially restored buggy behavior we shipped with in 7.0 (but nobody noticed) that is now noticeable in the COM source generator.
Testing
CI.
Risk
We'll ship with a major size regression for WinForms apps, but not much can be done about it.
IMPORTANT: If this backport is for a servicing release, please verify that:
The PR target branch is
release/X.0-staging, notrelease/X.0.If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.