Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0] Make CoreCLR/NativeAOT assembly compile with .subsections_via_symbols on Apple platforms #92544

Merged
merged 3 commits into from
Sep 27, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 23, 2023

Backport of #92520 to release/8.0

/cc @jkotas @filipnavara

Customer Impact

Building dotnet/runtime repo or building native AOT apps with recently released XCode 15 toolchain produces binaries with broken exception handling.

Testing

The fix validated by @vcsjones : #92297 (comment)

Risk

Low

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

@ghost
Copy link

ghost commented Sep 23, 2023

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #92520 to release/8.0

/cc @jkotas @filipnavara

Customer Impact

Testing

Risk

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

area-NativeAOT-coreclr

Milestone: -

@jkotas
Copy link
Member

jkotas commented Sep 24, 2023

Blocked - pending resolution of #92520 (comment) (I have not sent tactics email yet.)

@jkotas jkotas added the blocked Issue/PR is blocked on something - see comments label Sep 24, 2023
@jkotas jkotas removed the blocked Issue/PR is blocked on something - see comments label Sep 26, 2023
Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved. we will take for consideration in 8.0.x

@jeffschwMSFT jeffschwMSFT added the Servicing-consider Issue for next servicing release review label Sep 26, 2023
@jeffschwMSFT jeffschwMSFT added this to the 8.0.0 milestone Sep 26, 2023
@carlossanlop carlossanlop added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Sep 27, 2023
@carlossanlop
Copy link
Member

Approved by Tactics via email, but will hold from merging until the feedback indicated by @jkotas is addressed.

Blocked - pending resolution of #92520 (comment) (I have not sent tactics email yet.)

@carlossanlop carlossanlop added the blocked Issue/PR is blocked on something - see comments label Sep 27, 2023
@filipnavara
Copy link
Member

Approved by Tactics via email, but will hold from merging until the feedback indicated by @jkotas is addressed.

That was already addressed in the PRs targeting main. Hence why the blocked label was removed. Link to discussion: #92555 (comment)

@jkotas
Copy link
Member

jkotas commented Sep 27, 2023

That was already addressed in the PRs targeting main. Hence why the blocked label was removed.

Yep, this is ready to be merged.

@carlossanlop carlossanlop removed the blocked Issue/PR is blocked on something - see comments label Sep 27, 2023
@carlossanlop
Copy link
Member

Ah perfect, thanks for clarifying. I wanted to be completely sure. Merging now.

@carlossanlop carlossanlop merged commit 8c898a9 into release/8.0 Sep 27, 2023
113 of 116 checks passed
@carlossanlop carlossanlop deleted the backport/pr-92520-to-release/8.0 branch September 27, 2023 16:27
@ghost ghost locked as resolved and limited conversation to collaborators Oct 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-NativeAOT-coreclr Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants