Do not clone empty arrays in CloneByteArray #93231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/area-system-security, @bartonjs, @vcsjones Issue Details
If its empty, just return the identity to save the allocation.
|
filipnavara
approved these changes
Oct 9, 2023
vcsjones
commented
Oct 9, 2023
src/libraries/Common/src/System/Security/Cryptography/Helpers.cs
Outdated
Show resolved
Hide resolved
bartonjs
approved these changes
Oct 9, 2023
|
Failure is tracked in #93229. Merging. |
stephentoub
reviewed
Oct 10, 2023
Comment on lines
+48
to
+53
| return src switch | ||
| { | ||
| return null; | ||
| } | ||
|
|
||
| return (byte[])(src.Clone()); | ||
| null => null, | ||
| { Length: 0 } => src, | ||
| _ => (byte[])src.Clone(), | ||
| }; |
There was a problem hiding this comment.
FWIW, it could also have been:
return src is not null ? src.AsSpan().ToArray() : null;and let span's ToArray handle the empty case via Array.Empty.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CloneByteArrayis used heavily in S.S.Cryptography to create defensive copies of byte arrays. This is to avoid exposing any kind of mutability to callers.Clonehowever appears to create a newbyte[]for empty byte arrays every time. Empty arrays are not uncommon. It could be for a CNG property, it could be for key parameters, or otherAsnEncodedData.If its empty, just return the identity to save the allocation.