Add support for ref-readonly in the .NET interop source generators #97720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkoritzinsky
added
area-System.Runtime.InteropServices
source-generator
|
Tagging subscribers to this area: @dotnet/interop-contrib Issue DetailsTreat Fixes #97706
|
ghost
assigned 
AaronRobinsonMSFT
approved these changes
Jan 30, 2024
jtschuster
approved these changes
Jan 30, 2024
|
Adding runtime-infra for review for the Roslyn upgrade. |
This was referenced Jan 30, 2024
MichaelSimons
requested review from
a team
and removed request for
MichaelSimons
|
Looks like the Roslyn upgrade is being done in #97767. When that's merged, I'll revert the Roslyn reference changes here. |
Treat `ref readonly` the same as we treat `in`. Fixes dotnet#97706
jkoritzinsky
force-pushed
the
ref-readonly
branch
from
e48a3c1
to
1c18b04
Compare
|
Failures are known or an infra issue |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Treat
ref readonlythe same as we treatin.Fixes #97706