Make OCSP stapling tests more stable #97979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Tagging subscribers to this area: @dotnet/ncl, @bartonjs, @vcsjones Issue DetailsThe instability of the tests was caused by the tests racing with refreshing the OCSP staple on the background. This PR adds waiting for the background refresh to complete where it was assumed it will complete fast enough. I kept the tests running for a bit on my machine, and did not reproduce the failure after the changes.
|
wfurt
reviewed
Feb 5, 2024
src/libraries/System.Net.Security/src/System/Net/Security/SslStreamCertificateContext.Linux.cs
Show resolved
Hide resolved
bartonjs
reviewed
Feb 5, 2024
| @@ -18,6 +18,7 @@ namespace System.Net.Security.Tests; | |||
| public class SslStreamCertificateContextOcspLinuxTests | |||
| { | |||
| [Fact] | |||
| [PlatformSpecific(TestPlatforms.Linux)] | |||
There was a problem hiding this comment.
The class is named "OcspLinuxTests", can/should this attribute just be put on the class? (I think it works at that level)
|
CI Failures are unrelated. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #97836, #97779 and #97936.
The instability of the tests was caused by the tests racing with refreshing the OCSP staple on the background. This PR adds waiting for the background refresh to complete where it was assumed it will complete fast enough.
I kept the tests running for a bit on my machine, and did not reproduce the failure after the changes.