Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin wasi docker image in pipeline-with-resources.yml #98357

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

akoeplinger
Copy link
Member

No description provided.

@ghost ghost assigned akoeplinger Feb 13, 2024
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Feb 13, 2024
@pavelsavara
Copy link
Member

This would mean that for example bump to WASI SDK 22 in the VM images would automatically break runtime main. Is that what we want ?

cc @lewing

@akoeplinger
Copy link
Member Author

akoeplinger commented Feb 13, 2024

That's how the infrastructure team wants to maintain these images, yes. The point is getting OS etc. updates automatically.
If we know a new wasi sdk version breaks existing consumers then we need to create a new image.

I guess it'd makes sense to including the wasi sdk version number in the image name.

@pavelsavara
Copy link
Member

That's how the infrastructure team wants to maintain these images, yes. The point is getting OS etc. updates automatically. If we know a new wasi sdk version breaks existing consumers then we need to create a new image.

We don't know that, but WASI SDK 20 -> 21 required other changes to work. Like LLVM version bump.

@akoeplinger
Copy link
Member Author

I guess longer term we should move to using our own nuget packages for emsdk/wasi-sdk, then this wouldn't matter.

@akoeplinger
Copy link
Member Author

Merging since the floating tag refers to the same version so there's no point in wasting CI resources.

@akoeplinger akoeplinger merged commit eb0c20c into main Feb 13, 2024
15 of 141 checks passed
@akoeplinger akoeplinger deleted the akoeplinger-patch-1 branch February 13, 2024 15:03
@github-actions github-actions bot locked and limited conversation to collaborators Mar 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants