Disable STJ SG unit tests on x86 hardware. #99078
Conversation
ghost
assigned 
|
Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis |
| @@ -12,6 +12,7 @@ namespace System.Text.Json.SourceGeneration.UnitTests | |||
| [ActiveIssue("https://github.com/dotnet/runtime/issues/58226", TestPlatforms.Browser)] | |||
| [SkipOnCoreClr("https://github.com/dotnet/runtime/issues/71962", ~RuntimeConfiguration.Release)] | |||
| [SkipOnMono("https://github.com/dotnet/runtime/issues/92467")] | |||
There was a problem hiding this comment.
Was Mono is failing for different reason or was it failing on x86 arch? I am asking to know if we still need to keep this skipping.
There was a problem hiding this comment.
I think we can remove the Mono skip and possibly also the CoreCLR one since according to #71962 the issues we saw with Checked config also seemed to happen on x86 only.
There was a problem hiding this comment.
I should note that these unit tests are particularly resource intensive. They are there primarily to aid design-time development of the source generator, so I don't think we need to run them on every platform available.
Following up on feedback from #98994 this disables unit tests for x86 hardware as well. Fix #71962.