Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[browser][MT] Fix Promise cancelation #99397

Merged
merged 7 commits into from
Mar 8, 2024

Conversation

pavelsavara
Copy link
Member

@pavelsavara pavelsavara commented Mar 7, 2024

  • fixed compareExchangeI32 🤦‍♂️
  • unregister from FinalizationRegistry in upgrade_managed_proxy_to_strong_ref
  • more testing if the runtime is still running
  • testing if the promise holder is already disposed
  • added exit to RuntimeAPI
  • improve BlazorHosted WBT exit
  • make assert_runtime_running always throw, in order to really protect the code after it.
    • make it not configurable by dropping withAssertAfterExit

Contributes to #98721

- testing if the promise hoilder is already disposed
- added `exit` to `RuntimeAPI`
- unregister from `FinalizationRegistry` in `upgrade_managed_proxy_to_strong_ref`
- improve `BlazorHosted` WBT exit
@pavelsavara pavelsavara marked this pull request as ready for review March 8, 2024 06:38
@maraf
Copy link
Member

maraf commented Mar 8, 2024

Please, filter out the noise in SignalR test log
appsettings.json in server project

{
  "Logging": {
    "LogLevel": {
      "Default": "Information",
      "Microsoft.AspNetCore": "Warning"
    }
  }
}

@pavelsavara

This comment was marked as outdated.

@pavelsavara pavelsavara merged commit 8e23fec into dotnet:main Mar 8, 2024
37 checks passed
@pavelsavara pavelsavara deleted the browser_mt_gc_handle branch March 8, 2024 16:34
@github-actions github-actions bot locked and limited conversation to collaborators Apr 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants