Allow open delegates to nullables #857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Port of dotnet/runtime#42837. Won't win any perf prizes, but will do for now. I don't think the amount of work required for good support will ever meet the bar.
MichalStrehovsky
added
the
area-NativeAOT-coreclr
jkotas
reviewed
Mar 25, 2021
...tem.Private.Reflection.Core/src/System/Reflection/Runtime/MethodInfos/CustomMethodInvoker.cs
Show resolved
Hide resolved
I agree that it makes the test pass, but I am not sure whether partial slow implementation like this is an improvement. It may be better to just keep it broken and wait until somebody actually needs it. |
That will just mean we'll have a bug open and an extra ActiveIssue that we will have roll around from repo to repo. It felt like adding localized code that we will never have to touch will save us time taking care and feeding a bug forever. |
jkotas
approved these changes
Mar 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of dotnet/runtime#42837.
Won't win any perf prizes, but will do for now. I don't think the amount of work required for good support will ever meet the bar.