Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Labels to the Image config #120

Merged
merged 4 commits into from
Aug 19, 2022
Merged

Conversation

timheuer
Copy link
Member

Adds support for ContainerLabel item group properties.

<ItemGroup>
  <ContainerLabel Include="com.microsoft.created-by" Value="dotnet-sdk" />
  <ContainerLabel Include="com.microsoft.project-name" Value="$(MSBuildProjectName)" />
</ItemGroup>

@timheuer timheuer changed the title Add support for ExposedPorts to the Image config Add support for Labels to the Image config Aug 17, 2022
@baronfel
Copy link
Member

This is good to go now. I added an initial conventional label to prove that the mechanism works. On my local testing, we go from:

"Labels": null

to this:

"Labels": {
    "org.opencontainers.image.created": "2022-08-19T15:03:03.7298106Z"
}

Copy link
Member

@baronfel baronfel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@baronfel
Copy link
Member

Fixes #95

@baronfel baronfel merged commit a53f90c into dotnet:main Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants