Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for setting the User metadata item #374

Merged
merged 2 commits into from
Mar 3, 2023
Merged

Conversation

baronfel
Copy link
Member

@baronfel baronfel commented Mar 1, 2023

There is no validation on this, as it's very hard to do - the supported formats are

  • user name
  • user id
  • user name:group name
  • user id:group id
  • user id:group name
  • user name:group id

all of which should match either a name or an id from /etc/passwd, which we theoretically have access to through the layers, but that seems really extra to acquire, unTAR, parse and validate.

Closes #115

@baronfel baronfel requested a review from a team March 1, 2023 22:12
@baronfel
Copy link
Member Author

baronfel commented Mar 1, 2023

This builds on #358 so shouldn't merge until it does.

Copy link
Member

@vlada-shubina vlada-shubina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check if changes to CreateNewImageToolTask are needed.

@baronfel
Copy link
Member Author

baronfel commented Mar 3, 2023

I will rebase/patch up after #358 is merged

Base automatically changed from support-history to main March 3, 2023 16:10
@baronfel baronfel enabled auto-merge (squash) March 3, 2023 18:24
@baronfel baronfel merged commit 95de4b3 into main Mar 3, 2023
@baronfel baronfel deleted the support-user-group branch March 3, 2023 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants