Add task to compute base image tag from .NET 8 going forward #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baronfel
force-pushed
the
sdk-version-parsing-task
branch
from
9f972b1
to
16f3f16
Compare
Microsoft.NET.Build.Containers.IntegrationTests/TargetsTests.cs
Outdated
Show resolved
Hide resolved
vlada-shubina
approved these changes
Mar 13, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #198
This adds a new Task
ComputeDotnetBaseImageTagthat uses the current SDK version and user's desired TFM for the project. For .NET 8 and upwards, when targeting the SDK's current TFM, if the SDK itself is preview or rc then that has an impact on the desired base tag.I added a series of tests to cover this.