-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't infer UseMonoRuntime based on the RID #16909
Conversation
It is problematic when the RID is set in the .csproj, or when using RuntimeIdentifier_s_. We will require workloads to explicitly opt-in to the Mono runtime packs.
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Redth @jonathanpeppers The ios and android workloads may need to set UseMonoRuntime
in response to this.
Yup I've talked to @pjcollins about it and the changes are in progress in XA/XI. |
I think we already have it in, so hopefully will work when we get the newer dotnet/sdk: |
…me packs This is necessary after the changes from dotnet/sdk#16909.
* Update dotnet SDK to 6.0 Preview 4 Update the minimum and target version of the SDK to 6.0 Preview 4. Part of #53411 * Switch to using eng/targetingpacks.targets for redirecting runtime pack location in src/mono/sample * Fix binder tracing tests * Set UseMonoRuntime property so the dotnet SDK can pull the mono runtime packs This is necessary after the changes from dotnet/sdk#16909. * Move UseMonoRuntimeProperty and set it to false in coreclr Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com> Co-authored-by: Elinor Fung <elfung@microsoft.com>
It is problematic when the RID is set in the .csproj, or when using RuntimeIdentifier_s_.
We will require workloads to explicitly opt-in to the Mono runtime packs.