Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the sdk build to target net8.0 #28563

Merged
merged 18 commits into from
Nov 21, 2022
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Directory.Build.props
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
<!-- Default to all packages generating a corresponding symbol package -->
<IncludeSymbols>true</IncludeSymbols>
<IsShippingPackage>false</IsShippingPackage>
<SdkTargetFramework>net7.0</SdkTargetFramework>
<SdkTargetFramework>net8.0</SdkTargetFramework>
<ToolsetTargetFramework>$(SdkTargetFramework)</ToolsetTargetFramework>

<!-- VS for Mac may run on a lower version of .NET than the SDK is targeting, but needs to load the resolvers. So the resolvers and dependencies
Expand Down
2 changes: 1 addition & 1 deletion global.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"tools": {
"dotnet": "7.0.100-rc.1.22431.12",
"dotnet": "8.0.100-alpha.1.22513.4",
marcpopMSFT marked this conversation as resolved.
Show resolved Hide resolved
"runtimes": {
"dotnet": [
"$(VSRedistCommonNetCoreSharedFrameworkx6480PackageVersion)"
Expand Down
11 changes: 7 additions & 4 deletions src/Tests/Microsoft.NET.Publish.Tests/PublishTestUtils.cs
Original file line number Diff line number Diff line change
Expand Up @@ -9,29 +9,32 @@ namespace Microsoft.NET.Publish.Tests
{
internal static class PublishTestUtils
{
#if NET7_0
#if NET8_0

public static IEnumerable<object[]> SupportedTfms { get; } = new List<object[]>
{
new object[] { "netcoreapp3.1" },
new object[] { "net5.0" },
new object[] { "net6.0" },
new object[] { ToolsetInfo.CurrentTargetFramework }
new object[] { ToolsetInfo.CurrentTargetFramework },
new object[] { ToolsetInfo.NextTargetFramework }
};

// This list should contain all supported TFMs after net5.0
public static IEnumerable<object[]> Net5Plus { get; } = new List<object[]>
{
new object[] { "net5.0" },
new object[] { "net6.0" },
new object[] { ToolsetInfo.CurrentTargetFramework }
new object[] { ToolsetInfo.CurrentTargetFramework },
new object[] { ToolsetInfo.NextTargetFramework }
};

// This list should contain all supported TFMs after net6.0
public static IEnumerable<object[]> Net6Plus { get; } = new List<object[]>
{
new object[] { "net6.0" },
new object[] { ToolsetInfo.CurrentTargetFramework }
new object[] { ToolsetInfo.CurrentTargetFramework },
new object[] { ToolsetInfo.NextTargetFramework }
};
#else
#error If building for a newer TFM, please update the values above
Expand Down