Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid potential NRE #29128

Merged
merged 1 commit into from
Nov 18, 2022
Merged

Avoid potential NRE #29128

merged 1 commit into from
Nov 18, 2022

Conversation

tmat
Copy link
Member

@tmat tmat commented Nov 18, 2022

Add defensive null check.

Some tests in main are failing with NRE. These tests seem to pass in 7.0.2xx but it's not currently clear when RuntimeIdentifier and DefaultAppHostRuntimeIdentifier are non-null. Will follow up with adding null annotations in main.

Fixes #29085

@dotnet-issue-labeler dotnet-issue-labeler bot added the Area-AspNetCore RazorSDK, BlazorWebAssemblySDK, dotnet-watch label Nov 18, 2022
@tmat tmat enabled auto-merge (squash) November 18, 2022 18:48
@tmat tmat merged commit 48c7a4e into dotnet:release/7.0.2xx Nov 18, 2022
@tmat tmat deleted the FixNullRef branch November 18, 2022 21:17
marcpopMSFT pushed a commit that referenced this pull request Nov 18, 2022
@marek-safar
Copy link
Contributor

/backport to main

marek-safar pushed a commit that referenced this pull request Nov 21, 2022
marek-safar added a commit that referenced this pull request Nov 21, 2022
Co-authored-by: Tomáš Matoušek <tmat@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-AspNetCore RazorSDK, BlazorWebAssemblySDK, dotnet-watch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants