[7.0.2xx Servicing] Fix Property Parsing in publish and pack
#30826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…led correctly in publish
… the original code for 8 but not in the backport
nagilson
changed the title
publish and packpublish and pack
dsplaisted
approved these changes
Feb 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Backport of part of: #30265.
Will let this flow into 7.0.3xx automagically.
Customer Impact
Using the undefine property syntax
dotnet publish --property:Foo, properties delimited by ;, likedotnet publish -p:'Foo;Bar=Baz', or invalid properties such asdotnet publish --property:Foo=without a value will now either work (successfully undefine the property with the--property:Foosyntax) or fail elegantly and ignore. In 6.0 this would be OK or elegantly fail, in 7.0 we added a change (#25991) which broke this old behaviorpackandpublish. (Example of a customer reporting this: #30758). In Net 7.0, customers would see a KeyValueError when incorrect syntax is used, and the undefine property syntax would not work forpackandpublish.Regression?
Risk
Verification