Update Container User Id to react to changes in dotnet/dotnet-docker#4715 #34128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
baronfel
force-pushed
the
fix-new-dotnet-docker-user
branch
from
160d15e
to
acf76dd
Compare
rainersigwald
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dotnet/dotnet-docker#4715 changed the User Id for the Linux images, and we didn't update at the same time. A longer-term fix would detect and parse the user id from the specified container environment variable if it is present, but we haven't implemented that yet. That work is tracked in dotnet/sdk-container-builds#479.
This error has already been reported by a user in dotnet/dotnet-docker#4766.
Without this change, container images generated by our tooling from preview 6 onwards are broken unless the user
<ContainerUser>1654</ContainerUser>), ordocker run -u XXXX)