Parse User and Port Container Metadata from special environment variables #34154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Containers
baronfel
force-pushed
the
parse-ports-and-uid-from-env
branch
from
e3ece63
to
915fe51
Compare
baronfel
commented
Jul 21, 2023
src/Containers/Microsoft.NET.Build.Containers/ContainerBuilder.cs
Outdated
Show resolved
Hide resolved
src/Containers/Microsoft.NET.Build.Containers/ContainerHelpers.cs
Outdated
Show resolved
Hide resolved
src/Containers/Microsoft.NET.Build.Containers/ContainerHelpers.cs
Outdated
Show resolved
Hide resolved
src/Containers/Microsoft.NET.Build.Containers/ContainerBuilder.cs
Outdated
Show resolved
Hide resolved
src/Containers/Microsoft.NET.Build.Containers/ContainerHelpers.cs
Outdated
Show resolved
Hide resolved
src/Containers/Microsoft.NET.Build.Containers/Microsoft.NET.Build.Containers.csproj
Outdated
Show resolved
Hide resolved
src/Tests/Microsoft.NET.Build.Containers.IntegrationTests/CreateNewImageTests.cs
Outdated
Show resolved
Hide resolved
baronfel
commented
Jul 27, 2023
baronfel
commented
Jul 27, 2023
baronfel
force-pushed
the
parse-ports-and-uid-from-env
branch
from
6be96d5
to
9ce576b
Compare
|
The test failures are in C++/CLI test projects and have failed in other PRs, so shouldn't be considered as part of this. |
vlada-shubina
approved these changes
Jul 31, 2023
src/Containers/Microsoft.NET.Build.Containers/ContainerBuilder.cs
Outdated
Show resolved
Hide resolved
src/Containers/Microsoft.NET.Build.Containers/ContainerHelpers.cs
Outdated
Show resolved
Hide resolved
src/Containers/Microsoft.NET.Build.Containers/Microsoft.NET.Build.Containers.csproj
Outdated
Show resolved
Hide resolved
baronfel
force-pushed
the
parse-ports-and-uid-from-env
branch
from
9ce576b
to
a00d03c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes dotnet/sdk-container-builds#478
Fixes dotnet/sdk-container-builds#479
User Id and Ports can be set explicitly (through user-specified MSBuild properties), but also implicitly via container environment variables. These can even be set by the base images that users use.
When we encounter these environment variables, we should apply them to the container configuration.