-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up some code #42775
Clean up some code #42775
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for the Blazor changes.
…he path with a separator and checking the path since it was duplicate code in both places.
…e of these are security related.
@dotnet/product-construction I'm getting VMR synchronization failures in this PR in the VMR and source build legs. Any ideas? |
|
@MichaelSimons I suspect it might be the readme after all. I forgot we're no longer generating on the fly from the template as we moved the component list into its own file. I reverted the README changes in the VMR |
/azp run sdk-source-build |
Azure Pipelines successfully started running 1 pipeline(s). |
src/Tasks/Microsoft.NET.Build.Tasks/NugetContentAssetPreprocessor.cs
Outdated
Show resolved
Hide resolved
/azp run sdk-unified-build |
Azure Pipelines successfully started running 1 pipeline(s). |
…roval to stay consistent with UUID v5 Clarify the uuid.cs file usage
Appears to be hitting the new known templating test issue. |
/azp run dotnet-sdk-public-ci,sdk-source-build,sdk-unified-build |
Azure Pipelines successfully started running 3 pipeline(s). |
Suppression was approved. |
Check the unzip path before extracting to it
Switch to XxHash3 and XxHash64 which is for non-security usage.