Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add storage location to key vault config #43232

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mthalman
Copy link
Member

@mthalman mthalman commented Sep 4, 2024

The key vault config is misconfigured because it is missing storageLocation. Without this, it causes the following error when running secret-manager on this config file:

error : Unhandled Exception: System.NullReferenceException: Object reference not set to an instance of an object.
   at Microsoft.DncEng.SecretManager.SecretManifest.CreateStorage(Storage data) in /_/src/SecretManager/Microsoft.DncEng.SecretManager/SecretManifest.cs:line 96

This fixes it by adding the appropriate config to target SourceBuildKeyVault.

@mthalman mthalman requested review from a team as code owners September 4, 2024 17:18
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Request triage from a team member labels Sep 4, 2024
@mthalman mthalman enabled auto-merge (squash) September 4, 2024 17:32
@ellahathaway
Copy link
Member

Disabling auto-merge; I discovered that the PAT is not stored in our source-build keyvault but in dnceng-pipeline-secrets keyvault. Before making this change, we need to either 1) move our variable groups into our source-build keyvault and re-configure the service connection we use or 2) continue to ask FR for help when rotating this secret.

@ellahathaway
Copy link
Member

Also - the source-build bot PATs are currently being managed by the release team via their secret-management pipeline. I suppose the question now is whose responsibility it is to manage these secrets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants