Updating PrivateSourceBuilt elements in the Versions.props file correctly. #3469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ali-turan7
requested review from
MichaelSimons,
lbussell,
premun and
mthalman
as code owners
dotnet-issue-labeler
bot
added
area-upstream-fix
ali-turan7
changed the title
premun
reviewed
May 22, 2023
mthalman
reviewed
May 22, 2023
premun
reviewed
May 22, 2023
tkapin
reviewed
May 22, 2023
mthalman
reviewed
May 22, 2023
mthalman
reviewed
May 22, 2023
premun
reviewed
May 23, 2023
Co-authored-by: Přemek Vysoký <premek.vysoky@microsoft.com>
mthalman
approved these changes
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues:
#3344
#3385
Description
In .Net 8.0., the content of the relevant element has been obtained, and the very last part of the URL has been replaced using regex. But in .Net 7.0. and 6.0.* the entire content has been set to the SDK version.
Test
In DryRun mode, the submit-sorce-build-release-pr script has been called.
In the final phase, right before raising the PR, the creation of the pull request has been disabled.
The contents of the VersionsProps file were compared and printed to ensure that the desired changes were implemented correctly. The results for each version are shown below.
Test for 8.0
https://dev.azure.com/dnceng/internal/_build/results?buildId=2184104&view=logs&j=19992227-62fb-5b50-4e29-3b72bd33eea1&t=9281c869-17dc-5ef7-6bc6-1c1da071debd
Test for 7.0
https://dev.azure.com/dnceng/internal/_build/results?buildId=2185462&view=logs&j=19992227-62fb-5b50-4e29-3b72bd33eea1&t=9281c869-17dc-5ef7-6bc6-1c1da071debd
Test for 6.0
https://dev.azure.com/dnceng/internal/_build/results?buildId=2185416&view=logs&j=19992227-62fb-5b50-4e29-3b72bd33eea1&t=9281c869-17dc-5ef7-6bc6-1c1da071debd