Add a profile attribute to files in windows desktop runtime pack #4227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkoritzinsky
approved these changes
Mar 11, 2024
|
Isn't this possible without hardcoding all the assemblies? |
This is mostly following the way target pack does this, and the runtime seems to have more files than the target pack. |
sbomer
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a profile attribute to the RuntimeList.xml in windows desktop runtime pack, similar to the corresponding target pack. This is needed to fix issue 37088 and PR 39402 has the corresponding SDK fix.
The target pack uses System.Windows.Forms.FileClassification.props but the analyzer assemblies (
System.Windows.Forms.Analyzers.CSharp.dll,System.Windows.Forms.Analyzers.dll) causes problems and hence the runtime pack uses the assembly names explicitly. Also, the runtime pack has extra assemblies than the target pack. The assembly,System.Private.Windows.Core.dll, isn't tagged with a profile.