Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code coverage for RichTextBox #10921

Merged
merged 7 commits into from
Feb 22, 2024
Merged

Add code coverage for RichTextBox #10921

merged 7 commits into from
Feb 22, 2024

Conversation

Zheng-Li01
Copy link
Member

@Zheng-Li01 Zheng-Li01 commented Feb 21, 2024

related #10453

Proposed changes

  • Add unit tests for RichTextBox to test its GetCharIndexFromPosition() method

Customer Impact

  • None

Regression?

  • No

Risk

  • Minimal

Test methodology

  • Unit tests
Microsoft Reviewers: Open in CodeFlow

@Zheng-Li01 Zheng-Li01 requested a review from a team as a code owner February 21, 2024 06:09
@Zheng-Li01 Zheng-Li01 requested review from Tanya-Solyanik, SimonZhao888, LeafShi1 and Epica3055 and removed request for a team February 21, 2024 06:40
Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (da164d6) 73.16850% compared to head (642950e) 73.18126%.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #10921         +/-   ##
===================================================
+ Coverage   73.16850%   73.18126%   +0.01276%     
===================================================
  Files           3090        3090                 
  Lines         633647      633665         +18     
  Branches       47398       47398                 
===================================================
+ Hits          463630      463724         +94     
+ Misses        166460      166395         -65     
+ Partials        3557        3546         -11     
Flag Coverage Δ
Debug 73.18126% <100.00000%> (+0.01276%) ⬆️
integration 18.40114% <ø> (+0.00771%) ⬆️
production 46.66249% <ø> (+0.02656%) ⬆️
test 94.99530% <100.00000%> (+0.00025%) ⬆️
unit 43.52394% <ø> (-0.00175%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@Tanya-Solyanik Tanya-Solyanik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Is this one of the existing automation tests from the MadDog days?

@Zheng-Li01
Copy link
Member Author

Looks good. Is this one of the existing automation tests from the MadDog days?

Yes, this is one of the existing automation tests from the MadDog.

Zheng-Li01 and others added 2 commits February 22, 2024 09:56
…RichTextBoxTests.cs

Co-authored-by: Tanya Solyanik <tanyaso@microsoft.com>
…RichTextBoxTests.cs

Co-authored-by: Tanya Solyanik <tanyaso@microsoft.com>
@Zheng-Li01 Zheng-Li01 added the waiting-review This item is waiting on review by one or more members of team label Feb 22, 2024
@Tanya-Solyanik Tanya-Solyanik removed the waiting-review This item is waiting on review by one or more members of team label Feb 22, 2024
@Tanya-Solyanik Tanya-Solyanik merged commit 01d2b63 into dotnet:main Feb 22, 2024
8 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 9.0 Preview2 milestone Feb 22, 2024
KlausLoeffelmann pushed a commit to KlausLoeffelmann/winforms that referenced this pull request Mar 5, 2024
* Add unit test for RichTextBox control

Co-authored-by: Tanya Solyanik <tanyaso@microsoft.com>
@github-actions github-actions bot locked and limited conversation to collaborators Mar 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants