Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test coverage for Label #10976

Merged
merged 4 commits into from
Mar 7, 2024
Merged

Conversation

Olina-Zhang
Copy link
Member

@Olina-Zhang Olina-Zhang commented Mar 1, 2024

Related #10453

Proposed changes

  • Add unit tests for Label to test its properties: AutoEllipsis, BackgroundImage, BackgroundImageLayout, ImageIndex, ImageKey, ImageList, LiveSetting, UseCompatibleTextRendering
  • Add unit tests for Label to test its events: AutoSizeChanged, BackgroundImageChanged, BackgroundImageLayoutChanged, KeyUp, KeyDown, KeyPress, TabStopChanged, TextAlignChanged

Customer Impact

  • None

Regression?

  • No

Risk

  • Minimal

Test methodology

  • Unit tests
Microsoft Reviewers: Open in CodeFlow

Copy link

codecov bot commented Mar 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.20046%. Comparing base (dd5ae27) to head (61d20d5).
Report is 30 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #10976         +/-   ##
===================================================
+ Coverage   73.16610%   73.20046%   +0.03436%     
===================================================
  Files           3097        3097                 
  Lines         633907      634261        +354     
  Branches       47361       47364          +3     
===================================================
+ Hits          463805      464282        +477     
+ Misses        166541      166436        -105     
+ Partials        3561        3543         -18     
Flag Coverage Δ
Debug 73.20046% <100.00000%> (+0.03436%) ⬆️
integration 18.45076% <ø> (+0.01839%) ⬆️
production 46.70553% <ø> (+0.04448%) ⬆️
test 94.97896% <100.00000%> (+0.00499%) ⬆️
unit 43.60292% <ø> (+0.03931%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@Tanya-Solyanik Tanya-Solyanik added the 📭 waiting-author-feedback The team requires more information from the author label Mar 1, 2024
@dotnet-policy-service dotnet-policy-service bot removed the 📭 waiting-author-feedback The team requires more information from the author label Mar 4, 2024
Copy link
Member

@lonitra lonitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small suggestions, otherwise LGTM!

@lonitra lonitra added the 📭 waiting-author-feedback The team requires more information from the author label Mar 4, 2024
@Olina-Zhang Olina-Zhang removed the 📭 waiting-author-feedback The team requires more information from the author label Mar 5, 2024
@Olina-Zhang
Copy link
Member Author

Thank you all suggestion, avoid similar problems in the future as much as possible.

Copy link
Member

@Tanya-Solyanik Tanya-Solyanik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Tanya-Solyanik Tanya-Solyanik added the ready-to-merge PRs that are ready to merge but worth notifying the internal team. label Mar 5, 2024
@lonitra lonitra merged commit cd577d3 into dotnet:main Mar 7, 2024
8 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 9.0 Preview3 milestone Mar 7, 2024
@dotnet-policy-service dotnet-policy-service bot removed the ready-to-merge PRs that are ready to merge but worth notifying the internal team. label Mar 7, 2024
KlausLoeffelmann pushed a commit to KlausLoeffelmann/winforms that referenced this pull request Mar 7, 2024
* Add code coverage for Label

* Add test coverage for Label

* Update

* Update feedback
@Olina-Zhang Olina-Zhang deleted the Add_UnitTest_For_Label branch March 15, 2024 07:16
@github-actions github-actions bot locked and limited conversation to collaborators Apr 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants