Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code coverage for ProgressBarRenderer #11074

Merged
merged 4 commits into from
Mar 20, 2024
Merged

Add code coverage for ProgressBarRenderer #11074

merged 4 commits into from
Mar 20, 2024

Conversation

Zheng-Li01
Copy link
Member

@Zheng-Li01 Zheng-Li01 commented Mar 19, 2024

related #10453

Proposed changes

  • Add unit tests for ProgressBarRenderer to test its properties: IsSupported, ChunkThickness, ChunkSpaceThickness
  • Add unit tests for ProgressBarRenderer to test its methods: DrawHorizontalBar,DrawVerticalBar,DrawHorizontalChunks, DrawVerticalChunks

Customer Impact

  • None

Regression?

  • No

Risk

  • Minimal

Test methodology

  • Unit tests
Microsoft Reviewers: Open in CodeFlow

Copy link

codecov bot commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.37417%. Comparing base (59ee159) to head (5792743).
Report is 5 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #11074         +/-   ##
===================================================
+ Coverage   73.34756%   73.37417%   +0.02661%     
===================================================
  Files           3094        3095          +1     
  Lines         632670      632446        -224     
  Branches       46956       46861         -95     
===================================================
+ Hits          464048      464052          +4     
+ Misses        165141      164950        -191     
+ Partials        3481        3444         -37     
Flag Coverage Δ
Debug 73.37417% <100.00000%> (+0.02661%) ⬆️
integration 18.44946% <ø> (-0.00779%) ⬇️
production 46.87164% <ø> (+0.03260%) ⬆️
test 94.98368% <100.00000%> (+0.00122%) ⬆️
unit 43.78113% <ø> (+0.05979%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@Zheng-Li01 Zheng-Li01 added the waiting-review This item is waiting on review by one or more members of team label Mar 19, 2024
Copy link
Member

@Tanya-Solyanik Tanya-Solyanik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Tanya-Solyanik Tanya-Solyanik removed the waiting-review This item is waiting on review by one or more members of team label Mar 19, 2024
@lonitra lonitra merged commit 7de21be into dotnet:main Mar 20, 2024
8 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 9.0 Preview4 milestone Mar 20, 2024
@Zheng-Li01 Zheng-Li01 deleted the Add_Code_Coverage_For_ProgressBarRender branch March 21, 2024 01:06
@github-actions github-actions bot locked and limited conversation to collaborators Apr 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants