Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the BackColorChanged and BackgroundImageChanged event test cases in DateTimePickerTest.cs #11106

Merged
merged 2 commits into from
Mar 29, 2024

Conversation

John-Qiao
Copy link
Member

@John-Qiao John-Qiao commented Mar 22, 2024

related #10453

Proposed changes

  • Updated the BackColorChanged and BackgroundImageChanged event test cases in DateTimePickerTest.cs

1 DateTimePicker_BackColorChangedEvent_Raised_Success()
2 DateTimePicker_BackgroundImageChangedEvent_Raised_Success()

Customer Impact

  • None

Regression?

  • No

Risk

  • Minimal

Test methodology

  • Unit tests
Microsoft Reviewers: Open in CodeFlow

Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.39311%. Comparing base (0e896ce) to head (833c99b).
Report is 29 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #11106         +/-   ##
===================================================
- Coverage   73.40746%   73.39311%   -0.01436%     
===================================================
  Files           3098        3097          -1     
  Lines         632087      632152         +65     
  Branches       46635       46652         +17     
===================================================
- Hits          463999      463956         -43     
- Misses        164714      164809         +95     
- Partials        3374        3387         +13     
Flag Coverage Δ
Debug 73.39311% <100.00000%> (-0.01436%) ⬇️
integration 18.20363% <ø> (-0.05375%) ⬇️
production 46.80223% <ø> (-0.03780%) ⬇️
test 94.98183% <100.00000%> (-0.00169%) ⬇️
unit 43.88548% <ø> (+0.02629%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

lonitra
lonitra previously approved these changes Mar 25, 2024
Copy link
Member

@lonitra lonitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a small suggestion on using target type new

@Tanya-Solyanik Tanya-Solyanik added the 📭 waiting-author-feedback The team requires more information from the author label Mar 27, 2024
@dotnet-policy-service dotnet-policy-service bot removed the 📭 waiting-author-feedback The team requires more information from the author label Mar 28, 2024
Copy link
Member

@Tanya-Solyanik Tanya-Solyanik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@lonitra lonitra merged commit d94d234 into dotnet:main Mar 29, 2024
8 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 9.0 Preview4 milestone Mar 29, 2024
@github-actions github-actions bot locked and limited conversation to collaborators May 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants