Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit test for checkedListBox #11265

Merged
merged 5 commits into from
Apr 30, 2024

Conversation

Olina-Zhang
Copy link
Member

@Olina-Zhang Olina-Zhang commented Apr 24, 2024

Related #10453

Proposed changes

  • Add unit tests for CheckedListBox to test its properties: DataSource, DrawMode, ItemHeight, ThreeDCheckBoxes, UseCompatibleTextRendering

  • Add unit tests for CheckedListBox to test its events: DataSourceChanged, DisplayMemberChanged, ItemCheck, Click, MouseClick, MeasureItem, ValueMemberChanged

Customer Impact

  • None

Regression?

  • No

Risk

  • Minimal

Test methodology

  • Unit tests
Microsoft Reviewers: Open in CodeFlow

Copy link

codecov bot commented Apr 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.34986%. Comparing base (bde3c80) to head (fcdc7a7).
Report is 51 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #11265         +/-   ##
===================================================
- Coverage   74.35458%   74.34986%   -0.00472%     
===================================================
  Files           3009        3019         +10     
  Lines         624977      626593       +1616     
  Branches       46497       46603        +106     
===================================================
+ Hits          464699      465871       +1172     
- Misses        156874      157324        +450     
+ Partials        3404        3398          -6     
Flag Coverage Δ
Debug 74.34986% <100.00000%> (-0.00472%) ⬇️
integration 18.31098% <ø> (-0.05641%) ⬇️
production 47.00724% <ø> (+0.03838%) ⬆️
test 97.04328% <100.00000%> (-0.02186%) ⬇️
unit 43.95220% <ø> (+0.03952%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@lonitra lonitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small comments, LGTM otherwise 👍

@lonitra lonitra added the 📭 waiting-author-feedback The team requires more information from the author label Apr 29, 2024
@dotnet-policy-service dotnet-policy-service bot removed the 📭 waiting-author-feedback The team requires more information from the author label Apr 30, 2024
@lonitra lonitra merged commit 198704c into dotnet:main Apr 30, 2024
8 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 9.0 Preview5 milestone Apr 30, 2024
@Olina-Zhang Olina-Zhang deleted the Add_UnitTest_CheckedListBox branch May 7, 2024 01:46
@github-actions github-actions bot locked and limited conversation to collaborators Jun 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants