Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit test for DateTimePicker 6 events #11318

Merged

Conversation

John-Qiao
Copy link
Member

@John-Qiao John-Qiao commented May 7, 2024

related #10453

Proposed changes

  • Add unit tests for below 6 events
  1. BackgroundImageLayoutChanged
  2. Click
  3. DoubleClick
  4. ForeColorChanged
  5. PaddingChanged
  6. TextChanged

Customer Impact

  • None

Regression?

  • No

Risk

  • Minimal

Screenshots

Before

After

Test methodology

  • Unit tests
Microsoft Reviewers: Open in CodeFlow

… Click, DoubleClick, ForeColorChanged, PaddingChanged, TextChanged)
@John-Qiao John-Qiao requested a review from a team as a code owner May 7, 2024 07:52
Copy link

codecov bot commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.23047%. Comparing base (9a9d4a2) to head (6eeaea2).
Report is 36 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #11318         +/-   ##
===================================================
- Coverage   74.30944%   74.23047%   -0.07897%     
===================================================
  Files           3018        3021          +3     
  Lines         626230      626255         +25     
  Branches       46599       46698         +99     
===================================================
- Hits          465348      464872        -476     
- Misses        157479      157986        +507     
+ Partials        3403        3397          -6     
Flag Coverage Δ
Debug 74.23047% <100.00000%> (-0.07897%) ⬇️
integration 18.26780% <ø> (-0.03729%) ⬇️
production 46.88713% <ø> (-0.06046%) ⬇️
test 97.03957% <100.00000%> (-0.00074%) ⬇️
unit 43.84344% <ø> (-0.05278%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@ricardobossan ricardobossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@lonitra lonitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@lonitra lonitra merged commit 16a3960 into dotnet:main May 10, 2024
8 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 9.0 Preview5 milestone May 10, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jun 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants