Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit test case for DataGridView 16 events #11556

Merged

Conversation

John-Qiao
Copy link
Member

@John-Qiao John-Qiao commented Jun 20, 2024

related #10453

Proposed changes

  • Add unit tests for below 16 events
  1. ColumnHeadersBorderStyleChanged
  2. ColumnHeadersDefaultCellStyleChanged
  3. DataMemberChanged
  4. DataSourceChanged
  5. DefaultCellStyleChanged
  6. EditModeChanged
  7. GridColorChanged
  8. MultiSelectChanged
  9. ReadOnlyChanged
  10. RowHeadersBorderStyleChanged
  11. RowHeadersDefaultCellStyleChanged
  12. RowsDefaultCellStyleChanged
  13. CurrentCellChanged
  14. CurrentCellDirtyStateChanged
  15. SelectionChanged
  16. Sorted
Microsoft Reviewers: Open in CodeFlow

@John-Qiao John-Qiao requested a review from a team as a code owner June 20, 2024 06:11
@John-Qiao John-Qiao added the waiting-review This item is waiting on review by one or more members of team label Jun 20, 2024
Copy link

codecov bot commented Jun 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.50645%. Comparing base (566bec4) to head (7d0a6ca).

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #11556         +/-   ##
===================================================
+ Coverage   74.48439%   74.50645%   +0.02205%     
===================================================
  Files           3039        3039                 
  Lines         629066      629324        +258     
  Branches       46834       46834                 
===================================================
+ Hits          468556      468887        +331     
+ Misses        157154      157063         -91     
- Partials        3356        3374         +18     
Flag Coverage Δ
Debug 74.50645% <100.00000%> (+0.02205%) ⬆️
integration 17.88990% <ø> (-0.08859%) ⬇️
production 47.37462% <ø> (+0.02631%) ⬆️
test 96.97293% <100.00000%> (+0.00169%) ⬆️
unit 44.50334% <ø> (+0.16523%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@SimonZhao888 SimonZhao888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lonitra lonitra merged commit df56dcc into dotnet:main Jun 27, 2024
8 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 9.0 Preview7 milestone Jun 27, 2024
@dotnet-policy-service dotnet-policy-service bot removed the waiting-review This item is waiting on review by one or more members of team label Jun 27, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jul 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants