Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code coverage for monthcalendar #11619

Merged
merged 2 commits into from
Jul 10, 2024

Conversation

Zheng-Li01
Copy link
Member

@Zheng-Li01 Zheng-Li01 commented Jul 2, 2024

related #10453

Proposed changes

  • Add unit tests for MonthCalendar to test its properties:AccessibleName, RowOrColumnMajor, canGetDefaultActionInternal, GetColumnHeaderItems, IsPatternSupported, CanGetNameInternal, CanGetDescriptionInternal, ShowWeekNumbers
  • Add unit tests for MonthCalendar to test its methods: GetItem(), GetRowHeaders(), GetRowHeaderItems(), GetColumnHeaderItems(),
Microsoft Reviewers: Open in CodeFlow

Copy link

codecov bot commented Jul 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.62558%. Comparing base (d768c8b) to head (fb21662).
Report is 58 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #11619         +/-   ##
===================================================
+ Coverage   74.46325%   74.62558%   +0.16232%     
===================================================
  Files           3032        3041          +9     
  Lines         628874      630576       +1702     
  Branches       46847       46877         +30     
===================================================
+ Hits          468280      470571       +2291     
+ Misses        157244      156644        -600     
- Partials        3350        3361         +11     
Flag Coverage Δ
Debug 74.62558% <100.00000%> (+0.16232%) ⬆️
integration 17.98403% <ø> (-0.00403%) ⬇️
production 47.53701% <ø> (+0.21631%) ⬆️
test 96.98311% <100.00000%> (+0.01364%) ⬆️
unit 44.57721% <ø> (+0.27291%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@Zheng-Li01 Zheng-Li01 added the waiting-review This item is waiting on review by one or more members of team label Jul 2, 2024
@SimonZhao888 SimonZhao888 added 📭 waiting-author-feedback The team requires more information from the author and removed waiting-review This item is waiting on review by one or more members of team labels Jul 2, 2024
@dotnet-policy-service dotnet-policy-service bot removed the 📭 waiting-author-feedback The team requires more information from the author label Jul 3, 2024
@Zheng-Li01 Zheng-Li01 added the waiting-review This item is waiting on review by one or more members of team label Jul 3, 2024
@lonitra lonitra added ready-to-merge PRs that are ready to merge but worth notifying the internal team. and removed waiting-review This item is waiting on review by one or more members of team labels Jul 9, 2024
@Zheng-Li01 Zheng-Li01 closed this Jul 10, 2024
@Zheng-Li01 Zheng-Li01 deleted the Add_Code_Coverage_For_MonthCalendar branch July 10, 2024 07:04
@dotnet-policy-service dotnet-policy-service bot removed the ready-to-merge PRs that are ready to merge but worth notifying the internal team. label Jul 10, 2024
@Zheng-Li01 Zheng-Li01 restored the Add_Code_Coverage_For_MonthCalendar branch July 10, 2024 07:09
@Zheng-Li01 Zheng-Li01 reopened this Jul 10, 2024
@Zheng-Li01 Zheng-Li01 added the ready-to-merge PRs that are ready to merge but worth notifying the internal team. label Jul 10, 2024
@lonitra lonitra merged commit b2f5d63 into dotnet:main Jul 10, 2024
8 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 9.0 Preview7 milestone Jul 10, 2024
@dotnet-policy-service dotnet-policy-service bot removed the ready-to-merge PRs that are ready to merge but worth notifying the internal team. label Jul 10, 2024
@Zheng-Li01 Zheng-Li01 deleted the Add_Code_Coverage_For_MonthCalendar branch July 11, 2024 00:55
@github-actions github-actions bot locked and limited conversation to collaborators Aug 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants