Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for CheckedListBox and CheckedListBox.CheckedListBoxItemAccessibleObject #11647

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

Olina-Zhang
Copy link
Member

@Olina-Zhang Olina-Zhang commented Jul 10, 2024

Related #10453

Proposed changes

  • Add unit test for CheckedListBox to test its event: DrawItem
  • Add unit tests for CheckedListBox.CheckedListBoxItemAccessibleObject to test its property: AccessibleStates
Microsoft Reviewers: Open in CodeFlow

Copy link

codecov bot commented Jul 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.53546%. Comparing base (4b80b67) to head (e308c8f).

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #11647         +/-   ##
===================================================
+ Coverage   74.52745%   74.53546%   +0.00800%     
===================================================
  Files           3041        3041                 
  Lines         629560      629601         +41     
  Branches       46839       46840          +1     
===================================================
+ Hits          469195      469276         +81     
+ Misses        157008      156956         -52     
- Partials        3357        3369         +12     
Flag Coverage Δ
Debug 74.53546% <100.00000%> (+0.00800%) ⬆️
integration 17.87999% <ø> (-0.01266%) ⬇️
production 47.42337% <ø> (+0.01401%) ⬆️
test 96.97573% <100.00000%> (+0.00036%) ⬆️
unit 44.54951% <ø> (+0.04208%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@ricardobossan ricardobossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All LGTM

@Epica3055
Copy link
Member

looks good 💯

Copy link
Member

@lonitra lonitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@lonitra lonitra merged commit 2f5a725 into dotnet:main Jul 15, 2024
8 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 9.0 Preview7 milestone Jul 15, 2024
@Olina-Zhang Olina-Zhang deleted the CheckedListBox_UnitTest branch July 18, 2024 02:47
@github-actions github-actions bot locked and limited conversation to collaborators Aug 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants