Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add code coverage for treeview #11686

Merged
merged 2 commits into from
Jul 18, 2024
Merged

Add code coverage for treeview #11686

merged 2 commits into from
Jul 18, 2024

Conversation

Zheng-Li01
Copy link
Member

@Zheng-Li01 Zheng-Li01 commented Jul 17, 2024 •
edited by dotnet-policy-service bot
Loading

related #10453

Proposed changes

  • Add unit tests for TreeView to test its properties:CanGetDefaultActionInternal, CanGetNameInternal, IsItemSelected, CanGetValueInternal, VisibleCount
  • Add unit tests for TreeView to test its methods: Contains(), Reset()
Microsoft Reviewers: Open in CodeFlow

@Zheng-Li01 Zheng-Li01 requested a review from a team as a code owner July 17, 2024 06:58
@codecov Codecov
Copy link

codecov bot commented Jul 17, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.65422%. Comparing base (fa07c1b) to head (3dfac9a).
Report is 15 commits behind head on main.

Additional details and impacted files 
@@                 Coverage Diff                 @@
##                main      #11686         +/-   ##
===================================================
+ Coverage   74.55969%   74.65422%   +0.09452%     
===================================================
  Files           3041        3042          +1     
  Lines         629780      629884        +104     
  Branches       46845       46851          +6     
===================================================
+ Hits          469562      470235        +673     
+ Misses        156849      156282        -567     
+ Partials        3369        3367          -2
Flag Coverage Δ
Debug 74.65422% <100.00000%> (+0.09452%) ⬆️
integration 17.95924% <ø> (+0.08649%) ⬆️
production 47.63953% <ø> (+0.19279%) ⬆️
test 96.97921% <100.00000%> (+0.00095%) ⬆️
unit 44.68101% <ø> (+0.10855%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@Zheng-Li01 Zheng-Li01 added the waiting-review This item is waiting on review by one or more members of team label Jul 17, 2024
@lonitra lonitra added 📭 waiting-author-feedback The team requires more information from the author and removed waiting-review This item is waiting on review by one or more members of team labels Jul 17, 2024
@dotnet-policy-service dotnet-policy-service bot removed the 📭 waiting-author-feedback The team requires more information from the author label Jul 18, 2024
Tanya-Solyanik
Tanya-Solyanik approved these changes Jul 18, 2024
View reviewed changes
Copy link
Member

@Tanya-Solyanik Tanya-Solyanik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@lonitra lonitra merged commit 72c79eb into dotnet:main Jul 18, 2024
8 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 9.0 Preview7 milestone Jul 18, 2024
@Zheng-Li01 Zheng-Li01 deleted the Add_Code_Coverage_For_TreeView branch July 22, 2024 02:33
@LeafShi1 LeafShi1 mentioned this pull request Jul 24, 2024
Open
3 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Aug 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Tanya-Solyanik Tanya-Solyanik Tanya-Solyanik approved these changes

@lonitra lonitra lonitra approved these changes

Assignees

@Zheng-Li01 Zheng-Li01

Labels
None yet
Projects
None yet
Milestone
9.0 Preview7
Development

Successfully merging this pull request may close these issues.
3 participants
@Zheng-Li01 @Tanya-Solyanik @lonitra