Add code coverage for ToolStripTextBox #11848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zheng-Li01
added
the
waiting-review
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/10.0 #11848 +/- ##
======================================================
+ Coverage 74.84883% 75.04154% +0.19270%
======================================================
Files 3014 3036 +22
Lines 629414 630780 +1366
Branches 46716 46697 -19
======================================================
+ Hits 471109 473347 +2238
+ Misses 154944 154085 -859
+ Partials 3361 3348 -13
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Overall looks good.
@LeafShi1 @SimonZhao888 @Epica3055 @ricardobossan - could you please review this PR?
src/System.Windows.Forms/tests/UnitTests/System/Windows/Forms/ToolStripTextBoxTests.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms/tests/UnitTests/System/Windows/Forms/ToolStripTextBoxTests.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms/tests/UnitTests/System/Windows/Forms/ToolStripTextBoxTests.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms/tests/UnitTests/System/Windows/Forms/ToolStripTextBoxTests.cs
Show resolved
Hide resolved
src/System.Windows.Forms/tests/UnitTests/System/Windows/Forms/ToolStripTextBoxTests.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms/tests/UnitTests/System/Windows/Forms/ToolStripTextBoxTests.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms/tests/UnitTests/System/Windows/Forms/ToolStripTextBoxTests.cs
Outdated
Show resolved
Hide resolved
Tanya-Solyanik
added
📭 waiting-author-feedback
dotnet-policy-service
bot
removed
the
📭 waiting-author-feedback
Zheng-Li01
added
the
waiting-review
Tanya-Solyanik
approved these changes
Aug 12, 2024
src/System.Windows.Forms/tests/UnitTests/System/Windows/Forms/ToolStripTextBoxTests.cs
Show resolved
Hide resolved
Tanya-Solyanik
added
ready-to-merge
3 tasks
dotnet-policy-service
bot
removed
the
ready-to-merge
paul1956
pushed a commit
to paul1956/winforms
that referenced
this pull request
Aug 15, 2024
Add unit tests for toolstrip to test its properties & methods & events
paul1956
pushed a commit
to paul1956/winforms
that referenced
this pull request
Aug 15, 2024
Add unit tests for toolstrip to test its properties & methods & events
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related #10453
Proposed changes
Add unit tests for toolstrip to test its properties & methods & events
Microsoft Reviewers: Open in CodeFlow