Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code coverage for ToolStripMenuItem #11887

Merged

Conversation

Zheng-Li01
Copy link
Member

@Zheng-Li01 Zheng-Li01 commented Aug 15, 2024

related #10453

Proposed changes

Add unit tests for ToolStripMenuItem to test its properties & methods & events

Microsoft Reviewers: Open in CodeFlow

Copy link

codecov bot commented Aug 15, 2024

Codecov Report

Attention: Patch coverage is 98.85057% with 2 lines in your changes missing coverage. Please review.

Project coverage is 75.06378%. Comparing base (e4085eb) to head (d55a776).
Report is 30 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #11887         +/-   ##
===================================================
+ Coverage   75.01536%   75.06378%   +0.04841%     
===================================================
  Files           3047        3055          +8     
  Lines         631584      631860        +276     
  Branches       46764       46776         +12     
===================================================
+ Hits          473785      474298        +513     
+ Misses        154434      154185        -249     
- Partials        3365        3377         +12     
Flag Coverage Δ
Debug 75.06378% <98.85057%> (+0.04841%) ⬆️
integration 17.93044% <ø> (-0.00396%) ⬇️
production 48.21376% <ø> (+0.08912%) ⬆️
test 97.01667% <98.85057%> (+0.00020%) ⬆️
unit 45.24642% <ø> (+0.12028%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@LeafShi1 LeafShi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add #nullable enable in this file

@LeafShi1 LeafShi1 disabled auto-merge August 16, 2024 01:29
@LeafShi1 LeafShi1 added the 📭 waiting-author-feedback The team requires more information from the author label Aug 16, 2024
@dotnet-policy-service dotnet-policy-service bot removed the 📭 waiting-author-feedback The team requires more information from the author label Aug 20, 2024
@Epica3055 Epica3055 added the 📭 waiting-author-feedback The team requires more information from the author label Aug 21, 2024
@dotnet-policy-service dotnet-policy-service bot removed the 📭 waiting-author-feedback The team requires more information from the author label Aug 21, 2024
Epica3055
Epica3055 previously approved these changes Aug 21, 2024
Copy link
Member

@lonitra lonitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment about const otherwise LGTM

@lonitra lonitra added the 📭 waiting-author-feedback The team requires more information from the author label Aug 21, 2024
@dotnet-policy-service dotnet-policy-service bot removed the 📭 waiting-author-feedback The team requires more information from the author label Aug 22, 2024
Copy link
Member

@lonitra lonitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@lonitra lonitra merged commit 13c8ad6 into dotnet:main Aug 22, 2024
8 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0 Preview1 milestone Aug 22, 2024
@Zheng-Li01 Zheng-Li01 deleted the Add_Code_Coverage_For_ToolStripMenuItem branch September 4, 2024 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants