Add unit tests for InheritanceUI #12016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...ystem.Windows.Forms.Design/tests/UnitTests/System/Windows/Forms/Design/InheritanceUITests.cs
Outdated
Show resolved
Hide resolved
|
@ricardobossan - please add |
...ystem.Windows.Forms.Design/tests/UnitTests/System/Windows/Forms/Design/InheritanceUITests.cs
Show resolved
Hide resolved
...ystem.Windows.Forms.Design/tests/UnitTests/System/Windows/Forms/Design/InheritanceUITests.cs
Outdated
Show resolved
Hide resolved
...ystem.Windows.Forms.Design/tests/UnitTests/System/Windows/Forms/Design/InheritanceUITests.cs
Outdated
Show resolved
Hide resolved
...ystem.Windows.Forms.Design/tests/UnitTests/System/Windows/Forms/Design/InheritanceUITests.cs
Outdated
Show resolved
Hide resolved
...ystem.Windows.Forms.Design/tests/UnitTests/System/Windows/Forms/Design/InheritanceUITests.cs
Outdated
Show resolved
Hide resolved
...ystem.Windows.Forms.Design/tests/UnitTests/System/Windows/Forms/Design/InheritanceUITests.cs
Outdated
Show resolved
Hide resolved
Tanya-Solyanik
added
the
📭 waiting-author-feedback
dotnet-policy-service
bot
removed
the
📭 waiting-author-feedback
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12016 +/- ##
===================================================
+ Coverage 75.06578% 75.21714% +0.15135%
===================================================
Files 3063 3076 +13
Lines 632075 633123 +1048
Branches 46784 46820 +36
===================================================
+ Hits 474472 476217 +1745
+ Misses 154220 153503 -717
- Partials 3383 3403 +20
Flags with carried forward coverage won't be shown. Click here to find out more. |
Syareel-Sukeri
added
the
waiting-review
Tanya-Solyanik
added
📭 waiting-author-feedback
...ystem.Windows.Forms.Design/tests/UnitTests/System/Windows/Forms/Design/InheritanceUITests.cs
Show resolved
Hide resolved
| using static System.Windows.Forms.Design.ComponentTray; | ||
|
|
||
| namespace System.Windows.Forms.Design.Tests; | ||
|
|
||
| public sealed class InheritanceUITests | ||
| public static class RectangleAssertionsExtensions |
There was a problem hiding this comment.
Please move to a dedicated file. Preferably in utilities namespace. Please look for a good place, where it could be reused in other test assemblies.
There was a problem hiding this comment.
I have moved it to src/System.Windows.Forms.Primitives/tests/TestUtilities/FluentAssertions/FluentAssertExtensions.cs. Please let me know if this is an appropriate location.
There was a problem hiding this comment.
Yes, this is good, it will be accessible in other tests!
...ystem.Windows.Forms.Design/tests/UnitTests/System/Windows/Forms/Design/InheritanceUITests.cs
Outdated
Show resolved
Hide resolved
...ystem.Windows.Forms.Design/tests/UnitTests/System/Windows/Forms/Design/InheritanceUITests.cs
Outdated
Show resolved
Hide resolved
...ystem.Windows.Forms.Design/tests/UnitTests/System/Windows/Forms/Design/InheritanceUITests.cs
Show resolved
Hide resolved
dotnet-policy-service
bot
removed
the
📭 waiting-author-feedback
Syareel-Sukeri
added
the
waiting-review
Tanya-Solyanik
removed
the
waiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #10773
Proposed changes
Microsoft Reviewers: Open in CodeFlow