Add code coverage for RichTextBoxActionList #12131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardobossan
force-pushed
the
Issue_10773_Add_Coverage_For_RichTextBoxActionList
branch
from
6dfec29
to
ad6f07e
Compare
ricardobossan
added
waiting-review
ricardobossan
requested review from
Tanya-Solyanik,
lonitra,
LeafShi1,
SimonZhao888 and
Epica3055
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12131 +/- ##
===================================================
+ Coverage 75.23555% 75.26529% +0.02973%
===================================================
Files 3082 3086 +4
Lines 633299 633640 +341
Branches 46823 46839 +16
===================================================
+ Hits 476466 476911 +445
+ Misses 153436 153330 -106
- Partials 3397 3399 +2
Flags with carried forward coverage won't be shown. Click here to find out more. |
...ndows.Forms.Design/tests/UnitTests/System/Windows/Forms/Design/RichTextBoxActionListTests.cs
Outdated
Show resolved
Hide resolved
...ndows.Forms.Design/tests/UnitTests/System/Windows/Forms/Design/RichTextBoxActionListTests.cs
Outdated
Show resolved
Hide resolved
Tanya-Solyanik
added
📭 waiting-author-feedback
Related dotnet#10773 ## Proposed changes - Adds code coverage for `RichTextBoxActionList` - Coverage for the `EditLines()` method could not be added. The dependent method `EditorServiceContext.EditValue(_designer, Component!, "Lines")` is static and could not be mocked, and the dialog that opens during its execution requires manual intervention to close. ## Customer Impact - None or succinct description ## Regression? - No ## Risk - Minimal ## Test methodology - Unit tests ## Test environment(s) - 9.0.100-preview.7.24407.12
ricardobossan
force-pushed
the
Issue_10773_Add_Coverage_For_RichTextBoxActionList
branch
from
ad6f07e
to
2387b09
Compare
dotnet-policy-service
bot
removed
the
📭 waiting-author-feedback
ricardobossan
added
the
waiting-review
Tanya-Solyanik
approved these changes
Sep 18, 2024
dotnet-policy-service
bot
removed
the
waiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #10773
Proposed changes
RichTextBoxActionListEditLines()method could not be added. The dependent methodEditorServiceContext.EditValue(_designer, Component!, "Lines")is static and could not be mocked, and the dialog that opens during its execution requires manual intervention to close.Customer Impact
Regression?
Risk
Test methodology
Test environment(s)