Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code coverage for ToolStripLabel.cs file #12166

Merged

Conversation

Zheng-Li01
Copy link
Member

@Zheng-Li01 Zheng-Li01 commented Sep 18, 2024

related #10453

Proposed changes
Add unit tests for ToolStripLabe.cs to test its properties & methods & events

Microsoft Reviewers: Open in CodeFlow

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 98.59155% with 2 lines in your changes missing coverage. Please review.

Project coverage is 75.40976%. Comparing base (77da9f6) to head (18af4ce).
Report is 64 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #12166         +/-   ##
===================================================
+ Coverage   75.21424%   75.40976%   +0.19552%     
===================================================
  Files           3076        3101         +25     
  Lines         633053      634524       +1471     
  Branches       46814       46886         +72     
===================================================
+ Hits          476146      478493       +2347     
+ Misses        153515      152610        -905     
- Partials        3392        3421         +29     
Flag Coverage Δ
Debug 75.40976% <98.59155%> (+0.19552%) ⬆️
integration 18.00736% <ø> (-0.01755%) ⬇️
production 48.79425% <ø> (+0.30098%) ⬆️
test 97.02744% <98.59155%> (+0.00422%) ⬆️
unit 45.82999% <ø> (+0.33825%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@Tanya-Solyanik Tanya-Solyanik changed the title Add code coverage for ToolStripLabe.cs file Add code coverage for ToolStripLabel.cs file Sep 18, 2024
@Zheng-Li01 Zheng-Li01 added the waiting-review This item is waiting on review by one or more members of team label Sep 18, 2024
@Epica3055 Epica3055 added 📭 waiting-author-feedback The team requires more information from the author and removed waiting-review This item is waiting on review by one or more members of team labels Sep 18, 2024
Copy link
Member

@ricardobossan ricardobossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than small comments, LGTM

@dotnet-policy-service dotnet-policy-service bot removed the 📭 waiting-author-feedback The team requires more information from the author label Sep 19, 2024
@Zheng-Li01 Zheng-Li01 added the waiting-review This item is waiting on review by one or more members of team label Sep 20, 2024
ricardobossan
ricardobossan previously approved these changes Sep 20, 2024
@lonitra lonitra added 📭 waiting-author-feedback The team requires more information from the author and removed waiting-review This item is waiting on review by one or more members of team labels Sep 23, 2024
@dotnet-policy-service dotnet-policy-service bot removed the 📭 waiting-author-feedback The team requires more information from the author label Sep 24, 2024
Copy link
Member

@lonitra lonitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@lonitra lonitra merged commit 572782a into dotnet:main Sep 24, 2024
8 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0 Preview1 milestone Sep 24, 2024
@Zheng-Li01 Zheng-Li01 deleted the Add_code_coverage_for_ToolStripLabelTests branch September 26, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants