Revert "Explicit ImageList ownership management" (servicing) #4314
+34
−180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revert "Explicit ImageList ownership management. (dotnet#3601)" This reverts commit 03db3fb. Revert "Fix `ListView` no longer displays images (dotnet#4184)" This reverts commit d0608e7. We have observed an instability of tests under stress (and reasonably high degree of concurrency) presumably caused by ImageList lifetime handling (notably dotnet#3358). The changes introduced in dotnet#3601 have helped with tests stability, however resulted in a number of regressions, such as dotnet#4169 and dotnet#4275. Restore the original implementation given it worked reasonably well for the past so many years. (cherry picked from commit b0ee5da)
RussKie
added
the
Servicing-consider
Codecov Report
@@ Coverage Diff @@
## release/5.0 #4314 +/- ##
=====================================================
- Coverage 68.10735% 68.10196% -0.00539%
=====================================================
Files 1419 1419
Lines 510152 510022 -130
Branches 41553 41531 -22
=====================================================
- Hits 347451 347335 -116
+ Misses 156406 156396 -10
+ Partials 6295 6291 -4
Flags with carried forward coverage won't be shown. Click here to find out more. |
leecow
added
Servicing-approved
JeremyKuhne
approved these changes
Dec 7, 2020
ghost
mentioned this pull request
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 03db3fb.
Resolves #4169
Resolves #4275
Proposed changes
Revert "Explicit ImageList ownership management. (#3601)"
This reverts commit 03db3fb.
Revert "Fix
ListViewno longer displays images (#4184)"This reverts commit d0608e7.
We have observed an instability of tests under stress (and reasonably high degree of concurrency) presumably caused by ImageList lifetime handling (notably #3358).
The changes introduced in #3601 have helped with tests stability, however resulted in a number of regressions, such as #4169 and #4275.
Restore the original implementation given it worked reasonably well for the past so many years.
Customer Impact
ImageListbehaviours should be the same as in .NET Framework and .NET Core.Regression?
Risk
Microsoft Reviewers: Open in CodeFlow