Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Establish Code Coverage for WinForms testing #514

Merged
merged 10 commits into from
Mar 15, 2019
Merged

Establish Code Coverage for WinForms testing #514

merged 10 commits into from
Mar 15, 2019

Conversation

zsd4yr
Copy link
Contributor

@zsd4yr zsd4yr commented Mar 1, 2019

No description provided.

@zsd4yr zsd4yr requested a review from a team as a code owner March 1, 2019 00:33
@zsd4yr zsd4yr added the 🚫 * NO-MERGE * The PR is not ready for merge yet (see discussion for detailed reasons) label Mar 1, 2019
@sharwell sharwell force-pushed the dev/zadanz/coverage branch 12 times, most recently from 86e4667 to 9fe935e Compare March 8, 2019 14:54
@codecov
Copy link

codecov bot commented Mar 8, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@d0787d8). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #514   +/-   ##
=========================================
  Coverage          ?   24.09%           
=========================================
  Files             ?      888           
  Lines             ?   236127           
  Branches          ?    31923           
=========================================
  Hits              ?    56891           
  Misses            ?   175626           
  Partials          ?     3610
Flag Coverage Δ
#Debug 24.09% <ø> (?)
#production 17.71% <ø> (?)
#test 98.49% <ø> (?)

@sharwell sharwell force-pushed the dev/zadanz/coverage branch 3 times, most recently from 146a328 to c49620d Compare March 8, 2019 15:16
sharwell
sharwell reviewed Mar 8, 2019
View reviewed changes
eng/ci.yml Show resolved Hide resolved
sharwell
sharwell reviewed Mar 8, 2019
View reviewed changes
eng/ci.yml Show resolved Hide resolved
@sharwell
Copy link
Member

sharwell commented Mar 8, 2019

@dotnet/dotnet-winforms This PR should now be ready for review with intent to merge. It does not directly conflict with #224, but be aware that merging #224 may cause coverage information to be lost.

@sharwell sharwell removed the 🚫 * NO-MERGE * The PR is not ready for merge yet (see discussion for detailed reasons) label Mar 8, 2019
@sharwell sharwell force-pushed the dev/zadanz/coverage branch 2 times, most recently from 38835d0 to 97b0364 Compare March 9, 2019 18:44
@sharwell
Copy link
Member

@Tanya-Solyanik this is ready for review again

sharwell
sharwell reviewed Mar 11, 2019
View reviewed changes
eng/ci.yml Outdated
@@ -174,3 +174,53 @@ jobs:
- task: ms.vss-governance-buildtask.governance-build-task-component-detection.ComponentGovernanceComponentDetection@0
displayName: Component Governance Detection
condition: and(succeeded(), eq(variables['_BuildConfig'], 'Release'))

- job: Windows_NT_Coverage
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❗️ Someone should verify that this configuration will not run on non-public builds

@sharwell sharwell force-pushed the dev/zadanz/coverage branch 3 times, most recently from 54d04fd to 11f88f3 Compare March 13, 2019 02:18
zsd4yr
zsd4yr commented Mar 13, 2019
View reviewed changes
codecov.yml Show resolved Hide resolved
eng/CodeCoverage.proj Show resolved Hide resolved
eng/CodeCoverage.proj Show resolved Hide resolved
eng/CodeCoverage.proj Show resolved Hide resolved
eng/CodeCoverage.proj Show resolved Hide resolved
eng/Versions.props Outdated Show resolved Hide resolved
eng/ci.yml Show resolved Hide resolved
eng/ci.yml Show resolved Hide resolved
eng/ci.yml Outdated Show resolved Hide resolved
eng/packageContent.targets Show resolved Hide resolved
@zsd4yr
Copy link
Contributor Author

zsd4yr commented Mar 14, 2019 •
edited
Loading

@sharwell believe you should merge your clean-up branch into this one before merging this to master; is that your intention?

@sharwell
Copy link
Member

@zsd4yr No, my clean-up branch currently has no functional changes relative to this one so I'm planning to send it after this is merged.

@zsd4yr
Copy link
Contributor Author

zsd4yr commented Mar 14, 2019

@zsd4yr No, my clean-up branch currently has no functional changes relative to this one so I'm planning to send it after this is merged.

I would rather have all the changes come together 😃

zsd4yr
zsd4yr commented Mar 14, 2019
View reviewed changes
eng/ci.yml Outdated Show resolved Hide resolved
@sharwell
Copy link
Member

@zsd4yr I merged the updated comments and moved the upload task. There are some cleanup items I can't complete (currently the paths change in codecov.yml) until we have a baseline PR merged that it can compare results against.

@zsd4yr zsd4yr merged commit 1f0aead into master Mar 15, 2019
@zsd4yr zsd4yr deleted the dev/zadanz/coverage branch March 15, 2019 20:10
@ghost ghost locked as resolved and limited conversation to collaborators Feb 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alexperovich alexperovich alexperovich left review comments

@Tanya-Solyanik Tanya-Solyanik Tanya-Solyanik left review comments

@sharwell sharwell sharwell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zsd4yr @sharwell @alexperovich @Tanya-Solyanik