-
Notifications
You must be signed in to change notification settings - Fork 971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redo #224 which failed internal build #547
Conversation
Could you please explain what was incorrect and how you fixed it? Also how would you prove that this PR is correct? |
I am going to perform a build in the internal build system and link the results here to prove the issue is fixed. basically the issue was that a public build requires:
while an internal build requires:
and neither of the two parts for an internal build were satisfied. I wasn't aware of this until an internal build failed, so now I am going to validate with an internal build (which is a little tricky to do, but I'll get it done with some git magic) |
internal build has passed on same bit: https://dnceng.visualstudio.com/internal/_build/results?buildId=119029 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
#546 was incorrect