Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redo #224 which failed internal build #547

Merged
merged 13 commits into from
Mar 11, 2019
Merged

Redo #224 which failed internal build #547

merged 13 commits into from
Mar 11, 2019

Conversation

zsd4yr
Copy link
Contributor

@zsd4yr zsd4yr commented Mar 8, 2019

#546 was incorrect

@zsd4yr zsd4yr requested a review from a team as a code owner March 8, 2019 18:15
@Tanya-Solyanik
Copy link
Member

Could you please explain what was incorrect and how you fixed it? Also how would you prove that this PR is correct?

@zsd4yr
Copy link
Contributor Author

zsd4yr commented Mar 8, 2019

Could you please explain what was incorrect and how you fixed it? Also how would you prove that this PR is correct?

I am going to perform a build in the internal build system and link the results here to prove the issue is fixed.

basically the issue was that a public build requires:

  1. a Creator (for us this is our repository name: dotnet/winforms
  2. helix token to be empty ''

while an internal build requires:

  1. the Creator to be empty ''
  2. helix token to be a valid dotnet api helix token

and neither of the two parts for an internal build were satisfied. I wasn't aware of this until an internal build failed, so now I am going to validate with an internal build (which is a little tricky to do, but I'll get it done with some git magic)

@zsd4yr
Copy link
Contributor Author

zsd4yr commented Mar 8, 2019

internal build has passed on same bit: https://dnceng.visualstudio.com/internal/_build/results?buildId=119029

Copy link
Contributor

@JuditRose JuditRose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@zsd4yr zsd4yr merged commit 1779e07 into master Mar 11, 2019
@zsd4yr zsd4yr deleted the dev/zadanz/helix-redo branch March 11, 2019 17:24
@ghost ghost locked as resolved and limited conversation to collaborators Feb 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants