Common file dialogs new properties #7916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
ghost
requested review from
Merged
miloush
force-pushed
the
FileDialog-NewProperties
branch
from
21db908
to
14ade6e
Compare
miloush
force-pushed
the
FileDialog-NewProperties
branch
from
14ade6e
to
679c4f2
Compare
miloush
force-pushed
the
FileDialog-NewProperties
branch
from
679c4f2
to
1eb372d
Compare
dipeshmsft
approved these changes
Jul 7, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #7689. Based on #7244. (Summary of missing features #7248)
To review the new properties in this PR, see only the diff from the folder dialog PR:
miloush/wpf@FileDialog-PickFolders-Breaking...FileDialog-NewProperties
Description
This PR adds several of the missing properties of the common file dialog API:
CreateTestFile(FOS_NOTESTFILECREATE)ForcePreviewPane(FOS_FORCEPREVIEWPANEON)AddToRecent(FOS_DONTADDTORECENT)ShowHiddenItems(FOS_FORCESHOWHIDDEN)ClientGuid(IFileDialog.SetClientGuid)DefaultDirectory(IFileDialog.SetDefaultFolder)RootDirectory(IFileDialog2.SetNavigationRoot)The changes from the originally approved API are:
ShowHiddenItemsinstead ofShowHiddenFiles, following the disunification ofFileNamesandFolderNamesAllowReadOnlyItemsis dropped. It can only be enabled forOpenFileDialog, it cannot be disabled forSaveFileDialog. Users wishing to disallow read-only items inOpenFileDialogcan use theFileOkhandler instead.Testing
Compiled and tested on 8.0.0-preview.3.23174.8. Verified each property has an observable effect and is defined in an appropriate class.
Risk
These are all new properties.
DefaultDirectoryandRootDirectorycould technically be shell items rather than strings if the dialog is to support shell items in the future, but so couldInitialDirectorywhich is already present as string. The current use case is strong enough and the strings are allowed to be shell item parsing names anyway./cc @dipeshmsft
Microsoft Reviewers: Open in CodeFlow