Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modal documentation: fix deprecated memory= parameter #1057

Merged
merged 1 commit into from
Jul 20, 2024
Merged

Modal documentation: fix deprecated memory= parameter #1057

merged 1 commit into from
Jul 20, 2024

Conversation

Perdu
Copy link
Contributor

@Perdu Perdu commented Jul 20, 2024

memory= parameter is deprecated in favor of size=
See https://modal.com/docs/reference/changelog#062174-2024-05-17

Current doc example produces the following error:

/path/test_modal.py:56: DeprecationError: 2024-05-16: The `memory` parameter is deprecated. Use the `size='80GB'` parameter instead.
  @app.function(image=outlines_image, gpu=gpu.A100(memory=80))

@rlouf rlouf added examples Linked to usage examples documentation Linked to documentation and examples labels Jul 20, 2024
@rlouf rlouf merged commit 42c55bc into dottxt-ai:main Jul 20, 2024
6 checks passed
@rlouf
Copy link
Member

rlouf commented Jul 20, 2024

Thank you for updating the example!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Linked to documentation and examples examples Linked to usage examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Perdu @rlouf